Generate compile_commands.json into standard build directory

That it is the file ends up in Debug/compile_commands.json
instead of build/compile_commands.json.

This lines up the behaviour of the generator with that
of the code that generates a .clangd file in [ClangdConfigurationFileManager.java](https://github.com/eclipse-cdt/cdt-lsp/blob/ee297ee0ced1747352039e6ee25bcc80c10c7462/bundles/org.eclipse.cdt.lsp.clangd/src/org/eclipse/cdt/lsp/clangd/internal/config/ClangdConfigurationFileManager.java)
This code already supports vendors overriding to supply their
own (or extended) .clangd contents.

Author: jonahgraham

build/org.eclipse.cdt.managedbuilder.core.tests/tests/org/eclipse/cdt/managedbuilder/core/tests/CompilationDatabaseGenerationTest.java

@@ -44,7 +44,7 @@ public void testCompilationDatabaseGeneration() throws Exception {
 		final IProject app = loadProject("helloworldC");
 		setGenerateFileOptionEnabled(true);
 		app.build(IncrementalProjectBuilder.FULL_BUILD, null);
-		IFile compilationDatabase = app.getFile("build/compile_commands.json");
+		IFile compilationDatabase = app.getFile("Debug/compile_commands.json");
 		assertTrue(compilationDatabase.exists());
 	}
 
@@ -57,7 +57,7 @@ public void testJsonFormat() throws Exception {
 		final IProject app = loadProject("helloworldC");
 		setGenerateFileOptionEnabled(true);
 		app.build(IncrementalProjectBuilder.FULL_BUILD, null);
-		IFile commandsFile = app.getFile("build/compile_commands.json");
+		IFile commandsFile = app.getFile("Debug/compile_commands.json");
 		if (commandsFile.exists()) {
 
 			try (FileReader reader = new FileReader(commandsFile.getLocation().toFile())) {
@@ -88,7 +88,7 @@ public void testMultipleFiles() throws Exception {
 		IFile aFile = ManagedBuildTestHelper.createFile(app, "src/newFile.c");
 		setGenerateFileOptionEnabled(true);
 		app.build(IncrementalProjectBuilder.FULL_BUILD, null);
-		IFile commandsFile = app.getFile("build/compile_commands.json");
+		IFile commandsFile = app.getFile("Debug/compile_commands.json");
 		int numberOfElementsFound = 0;
 		boolean helloworldCIsPresent = false;
 		boolean newFileIsPresent = false;
@@ -122,7 +122,7 @@ public void isCPPFileAllowed() throws Exception {
 		final IProject app = loadProject("helloworldCPP");
 		setGenerateFileOptionEnabled(true);
 		app.build(IncrementalProjectBuilder.FULL_BUILD, null);
-		IFile commandsFile = app.getFile("build/compile_commands.json");
+		IFile commandsFile = app.getFile("Debug/compile_commands.json");
 		if (commandsFile.exists()) {
 
 			try (FileReader reader = new FileReader(commandsFile.getLocation().toFile())) {
@@ -151,7 +151,7 @@ public void testCompilationDatabaseGenerationNotEnabled() throws Exception {
 		final IProject app = loadProject("helloworldC");
 		setGenerateFileOptionEnabled(false);
 		app.build(IncrementalProjectBuilder.FULL_BUILD, null);
-		IFile compilationDatabase = app.getFile("build/compile_commands.json");
+		IFile compilationDatabase = app.getFile("Debug/compile_commands.json");
 		assertFalse(compilationDatabase.exists());
 	}
 

build/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/jsoncdb/generator/CompilationDatabaseGenerator.java

@@ -57,7 +57,6 @@
 public final class CompilationDatabaseGenerator {
 
 	private static final String CDB_FILENAME = "compile_commands.json"; //$NON-NLS-1$
-	private static final String BUILD_FOLDER = "build"; //$NON-NLS-1$
 	private static final String ERROR_MESSAGE = "Can not set contents to compile_commands.json file"; //$NON-NLS-1$
 
 	private IProject project;
@@ -77,14 +76,13 @@ public CompilationDatabaseGenerator(IProject proj, IConfiguration config) {
 	 * @param config
 	 */
 	public void generate() {
-
-		IPath buildDirectory = project.getFullPath()
-				.append(IPath.SEPARATOR + CompilationDatabaseGenerator.BUILD_FOLDER);
+		IPath buildDirectory = ManagedBuildManager.getBuildFullPath(configuration, configuration.getBuilder());
 		IPath compilationDatabasePath = buildDirectory
 				.append(IPath.SEPARATOR + CompilationDatabaseGenerator.CDB_FILENAME);
 		try {
-			if (!buildDirectory.toFile().exists()) {
-				createDirectory(CompilationDatabaseGenerator.BUILD_FOLDER);
+			IWorkspace workspace = ResourcesPlugin.getWorkspace();
+			if (!workspace.getRoot().exists(buildDirectory)) {
+				createDirectory(workspace.getRoot().getFolder(buildDirectory).getProjectRelativePath().toString());
 			}
 			IFile compileCommandsFile = createFile(compilationDatabasePath);
 			addToCompilationdatabase(project, compileCommandsFile, configuration);