Add a directory tracker to the CBS Makefile builder #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Messages such as "make: Entering directory" are now processed so that the scanner info builder knows the correct full path to use for build. Without this code calls to ToolChain.getResourcesFromCommand() would pass in the wrong directory and resources could not be reliably calculated. With the incorrect calculation the scanner info does not get applied to the file correctly and the file cannot be indexed reliably. TODO: - [ ] Decide how to handle make -j as "make: Entering directory" becomes unreliable - [ ] Consider whether we should search project for resources so that the exact build directory is less important - [ ] Consider how to report back to the user that the detected resource was not found in the project.
I think these TODO items can be split into future issues. When reviewing please let me know if you think they need to be dealt with. |
|
@ewaterlander can you have a look at this? Do you have the issues of changing directories in the middle of the build? BTW I have a handful of patches to Makefile flow in CBS as I am trying to dogfood while working on eclipse-equinox/equinox#831 (comment) |
|
Hi @jonahgraham We typically don't do directory changes in our builds, so I did not see this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages such as "make: Entering directory" are now processed so that the scanner info builder knows the correct full path to use for build.
Without this code calls to ToolChain.getResourcesFromCommand() would pass in the wrong directory and resources could not be reliably calculated. With the incorrect calculation the scanner info does not get applied to the file correctly and the file cannot be indexed reliably.
TODO: