Add BeanParam support in Jersey 2 client

[jerseyrobot]

Affected Versions

[2.25]

[jerseyrobot]

@glassfishrobot Commented
Reported by rachana.kumari

[jerseyrobot]

@glassfishrobot Commented
@pavelbucek said:
Please add code samples or some description about what the feature should provide (feel free to use paragraph below to have something to start with). Failing you to do so will result in closing this report as incomplete.

It makes natural sense to have this supported on the server side - you can inject Query/Path/Form/... params and other, runtime related obects. Most of them are not available on client side, because they simply don't exists in that scope. Also, how would that be accessed by the user? (Client is "a builder which returns a Response.. how would you get the instance of the annotated object? There is no "client resource" .. ).

Thanks and regards,
Pavel

[jerseyrobot]

@glassfishrobot Commented
rachana.kumari said:
I have business scenarios where I am fetching four query params and one path param combined into BeanParam from swagger in one of java component. Now, this component will pass same (four query param and one Path Param) ahead to other component using jersey client api. Now, my first component is client invoking call to other component. Client invocation is not supporting BeanParam while I am able to accep BeanParam at server end. My first component has to ipass each queryparam and path param separately as argument to client method which nvokes server rest method.

I have analysed jersey client code and I found issue. Please find code impact of jersey client to support BeanParam :-

1. WebResourceFactory : invoke method
2. WebresourceFactory : hasAnyParamAnnotation

[jerseyrobot]

@glassfishrobot Commented
alex-shpak said:
There is related pull request
https://github.com/jersey/jersey/pull/235

[jerseyrobot]

@glassfishrobot Commented
This issue was imported from java.net JIRA JERSEY-3221

[jerseyrobot]

• Issue Imported From: https://github.com/jersey/jersey/issues/3493
• Original Issue Raised By:@glassfishrobot
• Original Issue Assigned To: @pavelbucek

[andrei-ivanov]

Any chance to get the PR reviewed and merged? 😕

[senivam]

In order for this ( 235 ) PR to be reviewed some enthusiast shall re-publish it here (to new Jersey) with valid ECA signed. Afterwards it will be reviewed.

[jansupol]

The bean params are supported by the MP Rest Client which has similar functionality as the proxy client. The #4086 is using BeanParams. Would it help?

[andrei-ivanov]

@lucastsa any chance you would re-publish your PR here?

@jansupol not sure, in theory there's a single place where we create these client proxies, so the changes should be minimal, but I would also have to check if the MP Rest Client requires any other changes (we use the JAX-RS / Jersey / Spring / Spring Boot stack). One other thing is that #4086 seems yet to be merged, so I can't actually test.

[derekm]

@jansupol -- WebResourceFactory is still better, more mature, more battle-tested than MP Rest Client in several respects, despite missing BeanParams and ParamConverterProviders, etc.

For example, microprofile/microprofile-rest-client#217

It would be a good idea to continue to maintain WebResourceFactory & have WRF & MP Rest Client use the same backend abstractions/proxies. I'd like to see MP Rest Client move away from the fat, clunky RestClientBuilder API and towards the leaner, more advanced WRF API...