Terminate SseEventSource gracefully on HTTP 204 during (re)connect - #6120
Open
maho7791 wants to merge 1 commit into
Open
Terminate SseEventSource gracefully on HTTP 204 during (re)connect#6120maho7791 wants to merge 1 commit into
maho7791 wants to merge 1 commit into
Conversation
- EventProcessor now inspects the handshake response status: a 204 shuts the event source down gracefully using onComplete callback instead of scheduling further reconnects. - All other non-successful statuses are translated into the same WebApplicationException subtypes. - The translation logic is extracted from JerseyInvocation into a reusable static method instead of being duplicated. - Addes corresponding tests, that shows that new expecged behavior - Fixes eclipse-ee4j#6119 Signed-off-by: Mark Hoffmann <m.hoffmann@datainmotion.com>
This comment was marked as resolved.
This comment was marked as resolved.
Merged
📋 Eclipse License CheckStatus: ✅ Passed Full summary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EventProcessor now inspects the handshake response status: a 204 shuts the event source down gracefully using onComplete callback instead of scheduling further reconnects.
All other non-successful statuses are translated into the same WebApplicationException subtypes.
The translation logic is extracted from JerseyInvocation into a reusable static method instead of being duplicated.
Addes corresponding tests, that shows that new expecged behavior.
Fixes SseEventSource: HTTP 204 on (re)connect should terminate the event source gracefully instead of reconnecting forever #6119