Skip to content

Commit 1dc0e7f

Browse files
authored
Merge pull request #5311 from eclipse-ee4j/faces_issue_1567_regression_fix
Fixed regression error which caused spec1567IT to fail; the composite instance is needed further down in ComponentNotFoundException block
2 parents 131dc30 + d7029ed commit 1dc0e7f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

impl/src/main/java/com/sun/faces/renderkit/html_basic/AjaxBehaviorRenderer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ private static void appendIds(FacesContext facesContext,
319319

320320
boolean first = true;
321321

322-
UIComponent composite = (ajaxBehavior instanceof RetargetedAjaxBehavior) ? UIComponent.getCompositeComponentParent(component) : null;
322+
UIComponent composite = UIComponent.getCompositeComponentParent(component);
323323
String separatorChar = String.valueOf(getSeparatorChar(facesContext));
324324

325325
for (String id : ids) {
@@ -336,7 +336,7 @@ private static void appendIds(FacesContext facesContext,
336336

337337
boolean clientResolveableExpression = expression.equals("@all") || expression.equals("@none") || expression.equals("@form") || expression.equals("@this");
338338

339-
if (composite != null && (expression.equals("@this") || expression.startsWith("@this" + separatorChar))) {
339+
if (composite != null && (ajaxBehavior instanceof RetargetedAjaxBehavior) && (expression.equals("@this") || expression.startsWith("@this" + separatorChar))) {
340340
expression = expression.replaceFirst("@this", separatorChar + composite.getClientId(facesContext));
341341
clientResolveableExpression = false;
342342
}

0 commit comments

Comments
 (0)