Merge pull request #5411 from eclipse-ee4j/mojarra_issue_5404_reduce_logging_level_of_exception_which_is_already_rethrown

arjantijms · web-flow · commit ac4719dc2a2b · 2024-03-04T20:28:32.000+01:00
Reduce logging level of exception which is already rethrown
diff --git a/impl/src/main/java/com/sun/faces/lifecycle/ApplyRequestValuesPhase.java b/impl/src/main/java/com/sun/faces/lifecycle/ApplyRequestValuesPhase.java
@@ -52,8 +52,8 @@ public void execute(FacesContext facesContext) throws FacesException {
         } catch (RuntimeException re) {
             String exceptionMessage = re.getMessage();
             if (null != exceptionMessage) {
-                if (LOGGER.isLoggable(Level.WARNING)) {
-                    LOGGER.log(Level.WARNING, exceptionMessage, re);
+                if (LOGGER.isLoggable(Level.FINE)) {
+                    LOGGER.log(Level.FINE, exceptionMessage, re);
                 }
             }
             throw new FacesException(exceptionMessage, re);
diff --git a/impl/src/main/java/com/sun/faces/lifecycle/InvokeApplicationPhase.java b/impl/src/main/java/com/sun/faces/lifecycle/InvokeApplicationPhase.java
@@ -57,8 +57,8 @@ public void execute(FacesContext facesContext) throws FacesException {
         } catch (RuntimeException re) {
             String exceptionMessage = re.getMessage();
             if (null != exceptionMessage) {
-                if (LOGGER.isLoggable(Level.WARNING)) {
-                    LOGGER.log(Level.WARNING, exceptionMessage, re);
+                if (LOGGER.isLoggable(Level.FINE)) {
+                    LOGGER.log(Level.FINE, exceptionMessage, re);
                 }
             }
             throw new FacesException(exceptionMessage, re);
diff --git a/impl/src/main/java/com/sun/faces/lifecycle/ProcessValidationsPhase.java b/impl/src/main/java/com/sun/faces/lifecycle/ProcessValidationsPhase.java
@@ -50,8 +50,8 @@ public void execute(FacesContext facesContext) throws FacesException {
         } catch (RuntimeException re) {
             String exceptionMessage = re.getMessage();
             if (null != exceptionMessage) {
-                if (LOGGER.isLoggable(Level.WARNING)) {
-                    LOGGER.log(Level.WARNING, exceptionMessage, re);
+                if (LOGGER.isLoggable(Level.FINE)) {
+                    LOGGER.log(Level.FINE, exceptionMessage, re);
                 }
             }
             throw new FacesException(exceptionMessage, re);
diff --git a/impl/src/main/java/com/sun/faces/lifecycle/UpdateModelValuesPhase.java b/impl/src/main/java/com/sun/faces/lifecycle/UpdateModelValuesPhase.java
@@ -51,8 +51,8 @@ public void execute(FacesContext facesContext) {
         } catch (RuntimeException re) {
             String exceptionMessage = re.getMessage();
             if (null != exceptionMessage) {
-                if (LOGGER.isLoggable(Level.WARNING)) {
-                    LOGGER.log(Level.WARNING, exceptionMessage, re);
+                if (LOGGER.isLoggable(Level.FINE)) {
+                    LOGGER.log(Level.FINE, exceptionMessage, re);
                 }
             }
             throw new FacesException(exceptionMessage, re);

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ public void execute(FacesContext facesContext) throws FacesException {`
`52`	`52`	`} catch (RuntimeException re) {`
`53`	`53`	`String exceptionMessage = re.getMessage();`
`54`	`54`	`if (null != exceptionMessage) {`
`55`		`- if (LOGGER.isLoggable(Level.WARNING)) {`
`56`		`- LOGGER.log(Level.WARNING, exceptionMessage, re);`
	`55`	`+ if (LOGGER.isLoggable(Level.FINE)) {`
	`56`	`+ LOGGER.log(Level.FINE, exceptionMessage, re);`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`	`throw new FacesException(exceptionMessage, re);`
Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,8 @@ public void execute(FacesContext facesContext) throws FacesException {`
`57`	`57`	`} catch (RuntimeException re) {`
`58`	`58`	`String exceptionMessage = re.getMessage();`
`59`	`59`	`if (null != exceptionMessage) {`
`60`		`- if (LOGGER.isLoggable(Level.WARNING)) {`
`61`		`- LOGGER.log(Level.WARNING, exceptionMessage, re);`
	`60`	`+ if (LOGGER.isLoggable(Level.FINE)) {`
	`61`	`+ LOGGER.log(Level.FINE, exceptionMessage, re);`
`62`	`62`	`}`
`63`	`63`	`}`
`64`	`64`	`throw new FacesException(exceptionMessage, re);`
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,8 @@ public void execute(FacesContext facesContext) throws FacesException {`
`50`	`50`	`} catch (RuntimeException re) {`
`51`	`51`	`String exceptionMessage = re.getMessage();`
`52`	`52`	`if (null != exceptionMessage) {`
`53`		`- if (LOGGER.isLoggable(Level.WARNING)) {`
`54`		`- LOGGER.log(Level.WARNING, exceptionMessage, re);`
	`53`	`+ if (LOGGER.isLoggable(Level.FINE)) {`
	`54`	`+ LOGGER.log(Level.FINE, exceptionMessage, re);`
`55`	`55`	`}`
`56`	`56`	`}`
`57`	`57`	`throw new FacesException(exceptionMessage, re);`
Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,8 @@ public void execute(FacesContext facesContext) {`
`51`	`51`	`} catch (RuntimeException re) {`
`52`	`52`	`String exceptionMessage = re.getMessage();`
`53`	`53`	`if (null != exceptionMessage) {`
`54`		`- if (LOGGER.isLoggable(Level.WARNING)) {`
`55`		`- LOGGER.log(Level.WARNING, exceptionMessage, re);`
	`54`	`+ if (LOGGER.isLoggable(Level.FINE)) {`
	`55`	`+ LOGGER.log(Level.FINE, exceptionMessage, re);`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`throw new FacesException(exceptionMessage, re);`