Skip to content

Commit db8362c

Browse files
committed
[#25] avoid multiple defs in devices/boards/books
- use a Set instead of a list to collect installed packages
1 parent f6f7ecb commit db8362c

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

ilg.gnuarmeclipse.packs.data/src/ilg/gnuarmeclipse/packs/data/DataManager.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,11 @@
3434
import java.io.IOException;
3535
import java.util.ArrayList;
3636
import java.util.HashMap;
37+
import java.util.HashSet;
3738
import java.util.LinkedList;
3839
import java.util.List;
3940
import java.util.Map;
41+
import java.util.Set;
4042
import java.util.TreeMap;
4143

4244
import org.eclipse.core.runtime.IPath;
@@ -535,10 +537,10 @@ private List<PackNode> getInstalledPacksLatestVersionsList(DurationMonitor dm) {
535537
}
536538

537539
// Filter installed packages
538-
List<PackNode> installedPackages = new LinkedList<PackNode>();
540+
Set<PackNode> installedPackages = new HashSet<PackNode>();
539541
List<PackNode> packsVersionsList = getPacksVersionsList(dm);
540542
if (packsVersionsList != null) {
541-
for (PackNode versionNode : getPacksVersionsList(dm)) {
543+
for (PackNode versionNode : packsVersionsList) {
542544
if (versionNode.isBooleanProperty(Property.INSTALLED)) {
543545
installedPackages.add((PackNode) versionNode.getParent());
544546
}

0 commit comments

Comments
 (0)