Replies: 1 comment 4 replies
|
Hi @rsoika, I think your router is definitely worth integrating your router into GLSP! It looks really great from the video and I can imagine many people looking exactly for such a bevhavior! Overall, I think it makes more sense to give it a unique name and kind, such as "StickyManhattanRouter" because most of the route sticks to the original shape, to ensure that downstream projects are not getting their routing overwritten. Would you be willing to open a PR for it so we could do a proper code and integration review or are you offering for us to do that? Cheers, |
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi,
after being unhappy with the origin Sprotty Manhattan Router now for 3 years, I have finally managed to develop a new Manhattan Router :-)
The router is based on the main idea of Sprotty. The difference is how this router reacts when a connected element is moved. The origin Sprotty router recalculates the entire route from scratch, which often produces a completely different path or at least you lost a individual route. My new ManhattanRouter instead preserves the existing routing points and only adjusts the corners adjacent to the moved element. The nearest corner slides along its axis to follow the element while all intermediate bend points remain untouched.
This leads to a more intuitive routing in general.
Bildschirmaufzeichnung.vom.2026-03-21.08-56-21.webm
Modeling very complex models is making now fun.
I would like to contribute this new router to GLSP if you think it is worth. You can see my implementation here:
https://github.com/imixs/open-bpmn/blob/master/open-bpmn.glsp-client/open-bpmn-glsp/src/bpmn-manhattan-router.tsx
It is well documented so you can see what the router really does. (you know, I don't like uncommented source code ;-)
In my project the router is named
BPMNManhattanRouterbut this is just because it was developed within Open-BPMN. If the router makes it into the GLSP project, you could simply call it something likeManhattanRouter2with a newKINDand we offer it as an alternative.What do you all think about that?
Greetings
Ralph
All reactions