Multiple file extensions (diagram types) with the same GlspVscodeConnector

[jmenzies12]

Hey there,

Is this possible? Unsure if maybe I'm doing something wrong

Following #1167, I set up our diagram server similarly with a separate module for each diagram type registered against the same server module.

On the client side I created a single diagram server (SocketGlspVscodeServer) and vscode connector. Then I created an editor provider for each diagram type (passing the same vscode connector to both) and register that with vscode.

This worked initially with the diagrams loading and actions being performed correctly however I'm running into a weird error when the handleSetDirtyStateAction (onDidChangeCustomDocumentEventEmitter) is triggered. It throws a "No Custom Document found" error, however undo/redo work fine and the documents dirty state seems to be working fine.

If I remove the editor provider for one of the diagrams, the error goes away.

Cheers
Jonathan

[tortmayr]

@jmenzies12 Thanks for raising this issue.

I looked into this, and the problem is that the onDidChangeCustomDocument event from the connector fires on each changed document. Currently the editor provider just reuses this event as is. As a consequence the onDidChangeCustomDocument event for the editor provider might fire if a document was changed that has not been provided by this provider.

We need to filter the event properly down so that it only fires for documents of the provider itself.

I will create an issue for that.

[jmenzies12]

Hey @tortmayr,

Ahh okay, yep that makes sense. Thanks for addressing this and putting up the potential fix so quickly!

[tortmayr]

Should be fixed with
eclipse-glsp/glsp-vscode-integration#92

[reyesource]

It seems a good workaround for this issue is to use separate connector instances per editor type while sharing the single SocketGlspVscodeServer. Is this a safe, supported approach?

[tortmayr]

That definitely works as well.
I don't see any downsides to that approach.