[ELK] Layout is distorted on nested domain models with client layout

[paulreuter]

In the case of nested domain models with intermediates that are not represented in elk (e.g. GCompartments), there is a mismatch between GModel and ELK graph element hierarchy.

When applying coordinates from ELK to the GModel, this is accounted for - the ElkLayoutEngine.transfer*Layout methods call getOffset to transform to the correct coordinate system.

The reverse direction does not - the GModel coordinates are simply copied over to the ELK node. Simply subtracting the offset in my inherited LayoutEngine fixes any visual distortion.

[tortmayr]

Thanks for reporting this issue.
Sounds like you already found a proper fix.
Would you be willing to contribute this fix and open a PR?

[paulreuter]

Yes, but it'll be a bit before I get around to it.

[martin-fleck-at]

@paulreuter We are planning a new release before Christmas, do you think you will have some time to contribute your fix before that?