Skip to content

Commit 5516bf4

Browse files
Add VSS 5.1
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
1 parent 67edbf4 commit 5516bf4

File tree

7 files changed

+13
-10
lines changed

7 files changed

+13
-10
lines changed

data/vss-core/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ In addition older versions may be supported. This folder contains copies of all
2424
a branch without description. Descriptions are mandatory in VSS but that is currently not checked by vss-tools.
2525
However, KUKSA.val databroker requires description to be present.
2626
Use [VSS 3.1.1](https://github.com/COVESA/vehicle_signal_specification/releases/tag/v3.1.1) instead.
27+
* [VSS 5.1](https://github.com/COVESA/vehicle_signal_specification/releases/tag/v5.1) gives the `max` value for brake torque has float (`0.0`), even though the datapoint is an int16 value. This does not pass the KUKSA validator. In the VSS json we are shipping this issue has been rectified.
2728

2829
## Change process
2930

@@ -60,7 +61,7 @@ use the full name. When official release is created replace the copied *.json-fi
6061
Build and run kuksa_databroker using the new VSS file according to [documentation](../../README.md), e.g.
6162

6263
```sh
63-
$cargo run --bin databroker -- --metadata ./data/vss-core/vss_release_4.0.json
64+
$cargo run --bin databroker -- --metadata ./data/vss-core/vss_release_5.1.json
6465
```
6566

6667
Use the client to verify that changes in VSS are reflected, by doing e.g. set/get on some new or renamed signals.

data/vss-core/vss_release_5.1.json

Lines changed: 1 addition & 0 deletions
Large diffs are not rendered by default.

doc/opentelemetry/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ Enable the `otel` feature and start databroker binary with an increased buffer s
5050
```
5151
# in $workspace
5252
cargo build --features=otel
53-
OTEL_BSP_MAX_QUEUE_SIZE=8192 target/debug/databroker --vss data/vss-core/vss_release_4.0.json --enable-databroker-v1 --insecure
53+
OTEL_BSP_MAX_QUEUE_SIZE=8192 target/debug/databroker --vss data/vss-core/vss_release_5.1.json --enable-databroker-v1 --insecure
5454
```
5555

5656
Open the Jaeger UI at http://localhost:16686

doc/tls.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,20 +35,20 @@ KUKSA Databroker supports TLS, but not mutual authentication.
3535
As of today, if TLS is not configured, KUKSA Databroker will accept insecure connections.
3636

3737
```
38-
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_4.0.json
38+
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_5.1.json
3939
```
4040

4141
The default behavior may change in the future. By that reason, it is recommended to use the `--insecure` argument
4242
if you want to use insecure connections.
4343

4444
```
45-
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_4.0.json --insecure
45+
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_5.1.json --insecure
4646
```
4747

4848
To use a secure connection specify both `--tls-cert`and `--tls-private-key`
4949

5050
```
51-
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_4.0.json --tls-cert ../certificates/Server.pem --tls-private-key ../certificates/Server.key
51+
~/kuksa-databroker$ cargo run --bin databroker -- --metadata ../data/vss-core/vss_release_5.1.json --tls-cert ../certificates/Server.pem --tls-private-key ../certificates/Server.key
5252
```
5353

5454
Default certificates and keys are not included in the default KUKSA Databroker container,

integration_test/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ VSS_DATA_DIR="$SCRIPT_DIR/../data"
2828

2929
echo "Starting databroker container (\"${DATABROKER_IMAGE}\") in insecure mode, requesting platform (\"${CONTAINER_PLATFORM}\")"
3030
RUNNING_IMAGE=$(
31-
docker run -d -v ${VSS_DATA_DIR}:/data -p 55555:55555 --rm --platform ${CONTAINER_PLATFORM} ${DATABROKER_IMAGE} --metadata data/vss-core/vss_release_4.0.json --insecure --enable-databroker-v1
31+
docker run -d -v ${VSS_DATA_DIR}:/data -p 55555:55555 --rm --platform ${CONTAINER_PLATFORM} ${DATABROKER_IMAGE} --metadata data/vss-core/vss_release_5.1.json --insecure --enable-databroker-v1
3232
)
3333

3434
python3 -m pytest -v "${SCRIPT_DIR}/test_databroker.py"

integration_test/viss/readme.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ pip install pytest pytest-bdd allure-pytest-bdd requests websocket-client paho-m
3939

4040
Start databroker from project root:
4141
```
42-
RUST_LOG=debug cargo run --bin databroker --release --features viss -- --vss data/vss-core/vss_release_4.0.json --insecure --enable-viss --viss-address 0.0.0.0 --viss-port 8090
42+
RUST_LOG=debug cargo run --bin databroker --release --features viss -- --vss data/vss-core/vss_release_5.1.json --insecure --enable-viss --viss-address 0.0.0.0 --viss-port 8090
4343
```
4444

4545
> RUST_LOG=debug enables debug log messages of databroker, which shows incoming and outgoing VISS requests and makes it easier to troubleshoot failing tests.
@@ -80,7 +80,7 @@ _Setup:_ Clone kuksa-common for pre-built JWT tokens for testing purposes.
8080
Start databroker with public key using `--jwt-public-key` to enable validation of access tokens:
8181

8282
```
83-
RUST_LOG=debug cargo run --bin databroker --release --features viss -- --vss data/vss-core/vss_release_4.0.json --insecure --enable-databroker-v1 --enable-viss --viss-address 0.0.0.0 --viss-port 8090 --jwt-public-key kuksa-common/jwt/jwt.key.pub
83+
RUST_LOG=debug cargo run --bin databroker --release --features viss -- --vss data/vss-core/vss_release_5.1.json --insecure --enable-databroker-v1 --enable-viss --viss-address 0.0.0.0 --viss-port 8090 --jwt-public-key kuksa-common/jwt/jwt.key.pub
8484
```
8585

8686
Re-run tests:

scripts/Dockerfile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,13 @@ COPY ./dist/$TARGETARCH/sbom.json /app/sbom.json
5050
COPY ./dist/$TARGETARCH/thirdparty-licenses/ /app/thirdparty-licenses
5151

5252

53-
COPY ./data/vss-core/vss_release_3.1.1.json vss_release_3.1.1.json
5453
COPY ./data/vss-core/vss_release_4.0.json vss_release_4.0.json
54+
COPY ./data/vss-core/vss_release_5.1.json vss_release_5.1.json
55+
5556

5657
ENV KUKSA_DATABROKER_ADDR=0.0.0.0
5758
ENV KUKSA_DATABROKER_PORT=55555
58-
ENV KUKSA_DATABROKER_METADATA_FILE=vss_release_4.0.json
59+
ENV KUKSA_DATABROKER_METADATA_FILE=vss_release_5.1.json
5960

6061
EXPOSE $KUKSA_DATABROKER_PORT
6162

0 commit comments

Comments
 (0)