fix(ui): initialize unconfigured wireless interface to resolve NPE, fix channel selection on hardware tab, fix validation message on empty password (#11)

* fix(ui): fix un-initialized GwtNetInterfaceConfig for active wifi configuration, set to DISABLED

Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>

* fix(ui): fix channel text selection for wireless Hardware tab, could cause ArrayOutOfBoundsException

Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>

* fix(ui): change validator order to check first for password emptyness

Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>

---------

Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
Co-authored-by: Salvatore Coppola <83589980+salvatore-coppola@users.noreply.github.com>

Author: marcellorinaldo

bundles/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/network/TabWirelessUi.java

@@ -1794,7 +1794,7 @@ private void updateChannelListValues(List<GwtWifiChannelFrequency> freqChannels)
         if (this.activeConfig != null && this.activeConfig.getChannels() != null
                 && !this.activeConfig.getChannels().isEmpty()) {
             this.netTabs.hardwareTab.channel
-                    .setText(this.channelList.getItemText(this.activeConfig.getChannels().get(0)));
+                    .setText(this.channelList.getItemText(selectedChannelValue));
 
             this.channelList.setSelectedIndex(selectedChannelValue);
         }

bundles/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/validator/GwtValidators.java

@@ -53,9 +53,9 @@ public static List<Validator<String>> newPassword(final Optional<String> identit
 
         final List<Validator<String>> defaultValidators = new ArrayList<>();
 
+        defaultValidators.add(nonEmpty(MSGS.pwdEmpty()));
         defaultValidators.add(stringLength(255, MSGS.pwdMaxLength()));
         defaultValidators.add(noWhitespaceCharacters(MSGS.pwdWhitespaceCharacters()));
-        defaultValidators.add(nonEmpty(MSGS.pwdEmpty()));
 
         identityName.ifPresent(
                 id -> defaultValidators.add(notEqualsIdentityName(id, MSGS.pwdStrengthNotEqualsIdentityName())));

bundles/org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/shared/model/GwtWifiNetInterfaceConfig.java

@@ -110,7 +110,8 @@ public void setWifiConfig(GwtWifiConfig wifiConfig) {
 
     public GwtWifiConfig getActiveWifiConfig() {
         GwtWifiWirelessMode wifiMode = getWirelessModeEnum();
-        GwtWifiConfig activeConfig = null;
+        GwtWifiConfig activeConfig = new GwtWifiConfig();
+        activeConfig.setWirelessMode(wifiMode.name());
 
         if (wifiMode.equals(GwtWifiWirelessMode.netWifiWirelessModeAccessPoint)) {
             activeConfig = this.m_accessPointWifiConfig;