fix(ui): NPE on notEqualsIdentityName password validators#22
Merged
salvatore-coppola merged 2 commits intodevelopfrom Jan 12, 2026
Merged
fix(ui): NPE on notEqualsIdentityName password validators#22salvatore-coppola merged 2 commits intodevelopfrom
salvatore-coppola merged 2 commits intodevelopfrom
Conversation
|
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>
salvatore-coppola
force-pushed
the
fix/null-pointers-pass-validators
branch
from
57dbd8f to
dc5040b
Compare
| public static Validator<String> notEqualsIdentityName(final String identityName, final String message) { | ||
| return new ValidatorWrapper<>(new PredicateValidator(v -> !v.equalsIgnoreCase(identityName), message), Priority.MEDIUM); | ||
| return new ValidatorWrapper<>(new PredicateValidator(v -> { | ||
| if (v == null) { |
Member
There was a problem hiding this comment.
v== null is valid ? It seems strange to me, is it possible to submit a null password ?
Member
Author
There was a problem hiding this comment.
Yes, when the fields is first shown on the UI its value is null. Note that also the other validators are performing a null check
salvatore-coppola
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some null pointer exceptions that arise when the input has just been created and is null