Skip to content

Commit 47f525b

Browse files
committed
fix: Made kura.nn dependency to linux.position optional
Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>
1 parent 9828224 commit 47f525b

7 files changed

Lines changed: 32 additions & 9 deletions

File tree

kura/org.eclipse.kura.linux.position/META-INF/MANIFEST.MF

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@ Import-Package: de.taimos.gpsd4java.api;version="[1.0,2.0)",
2121
org.eclipse.kura.usb;version="[1.0,2.0)",
2222
org.osgi.framework,
2323
org.osgi.service.component;version="1.2.0",
24+
org.osgi.service.condition;version="[1.0,2.0)",
2425
org.osgi.service.event;version="1.3.0",
2526
org.osgi.service.io;version="1.0.0",
2627
org.osgi.util.measurement;version="1.0.1",
2728
org.osgi.util.position;version="1.0.1",
2829
org.slf4j;version="1.6.4"
2930
Export-Package: org.eclipse.kura.linux.position.options;version="1.0.0";x-internal:=true,
30-
org.eclipse.kura.linux.position.provider;version="1.0.0";x-internal:=true
31+
org.eclipse.kura.linux.position.provider;version="1.1.0";x-internal:=true

kura/org.eclipse.kura.linux.position/build.properties

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,7 @@ bin.includes = .,\
1717
about.html,\
1818
about_files/
1919
source.. = src/main/java/
20-
additional.bundles = org.eclipse.kura.api,\
21-
slf4j.api,\
22-
org.eclipse.osgi,\
23-
org.eclipse.osgi.util,\
24-
org.eclipse.equinox.io
20+
additional.bundles = org.osgi.service.component.annotations,\
21+
org.osgi.service.metatype.annotations
2522
src.includes = about.html,\
2623
about_files/

kura/org.eclipse.kura.linux.position/pom.xml

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,13 @@
3232
<kura.basedir>${project.basedir}/..</kura.basedir>
3333
<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/../test/org.eclipse.kura.linux.position.test/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
3434
</properties>
35+
36+
<build>
37+
<plugins>
38+
<plugin>
39+
<groupId>biz.aQute.bnd</groupId>
40+
<artifactId>bnd-maven-plugin</artifactId>
41+
</plugin>
42+
</plugins>
43+
</build>
3544
</project>

kura/org.eclipse.kura.nm/META-INF/MANIFEST.MF

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ Import-Package: jakarta.xml.bind;version="4.0.0",
2929
org.eclipse.kura.linux.net.dns;version="[1.1,2.0)",
3030
org.eclipse.kura.linux.net.iptables;version="[1.0,2.0)",
3131
org.eclipse.kura.linux.net.util;version="[1.0,2.0)",
32-
org.eclipse.kura.linux.position.options;version="[1.0,2.0)",
33-
org.eclipse.kura.linux.position.provider;version="[1.0,1.1)",
32+
org.eclipse.kura.linux.position.options;version="[1.0,2.0)";resolution:=optional,
33+
org.eclipse.kura.linux.position.provider;version="[1.1,2.0)";resolution:=optional,
3434
org.eclipse.kura.net;version="[2.4,3.0)",
3535
org.eclipse.kura.net.configuration;version="[1.1,2.0)",
3636
org.eclipse.kura.net.dhcp;version="[1.2,2.0)",
@@ -49,6 +49,7 @@ Import-Package: jakarta.xml.bind;version="4.0.0",
4949
org.eclipse.kura.usb;version="[1.0,2.0)",
5050
org.osgi.framework;version="1.5.0",
5151
org.osgi.service.component;version="1.2.0",
52+
org.osgi.service.condition;version="[1.0.0,2.0.0)",
5253
org.osgi.service.event;version="1.3.0",
5354
org.osgi.service.io;version="1.0.0",
5455
org.osgi.service.useradmin;version="1.0.0",

kura/org.eclipse.kura.nm/build.properties

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,5 @@ bin.includes = .,\
3434
lib/jnr-x86asm-1.0.2.jar
3535
src.includes = about.html,\
3636
about_files
37+
additional.bundles = org.osgi.service.component.annotations,\
38+
org.osgi.service.metatype.annotations

kura/org.eclipse.kura.nm/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,10 @@
123123
</execution>
124124
</executions>
125125
</plugin>
126+
<plugin>
127+
<groupId>biz.aQute.bnd</groupId>
128+
<artifactId>bnd-maven-plugin</artifactId>
129+
</plugin>
126130
</plugins>
127131
</build>
128132
</project>

kura/org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/position/MMPositionProvider.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2024 Eurotech and/or its affiliates and others
2+
* Copyright (c) 2024, 2025 Eurotech and/or its affiliates and others
33
*
44
* This program and the accompanying materials are made
55
* available under the terms of the Eclipse Public License 2.0
@@ -24,6 +24,7 @@
2424

2525
import org.eclipse.kura.linux.position.options.PositionServiceOptions;
2626
import org.eclipse.kura.linux.position.provider.GpsDeviceAvailabilityListener;
27+
import org.eclipse.kura.linux.position.provider.LinuxPositionProviderConstants;
2728
import org.eclipse.kura.linux.position.provider.LockStatusListener;
2829
import org.eclipse.kura.linux.position.provider.PositionProvider;
2930
import org.eclipse.kura.linux.position.provider.PositionProviderType;
@@ -35,10 +36,18 @@
3536
import org.freedesktop.dbus.types.UInt32;
3637
import org.freedesktop.dbus.types.Variant;
3738
import org.freedesktop.modemmanager1.modem.Location;
39+
import org.osgi.service.component.annotations.Component;
40+
import org.osgi.service.component.annotations.Reference;
41+
import org.osgi.service.condition.Condition;
3842
import org.osgi.util.position.Position;
3943
import org.slf4j.Logger;
4044
import org.slf4j.LoggerFactory;
4145

46+
@Component(name = "ModemManagerPositionProvider", //
47+
property = "service.pid=org.eclipse.kura.nm.position.MMPositionProvider", //
48+
reference = @Reference(name = "LinuxPositionProviderCondition", service = Condition.class, //
49+
target = "(" + Condition.CONDITION_ID + "=" + LinuxPositionProviderConstants.CONDITION_ID + ")" //
50+
))
4251
public class MMPositionProvider implements PositionProvider {
4352

4453
private static final Logger logger = LoggerFactory.getLogger(MMPositionProvider.class);

0 commit comments

Comments
 (0)