refactor: better variable name & remove unnecessary variable

mattdibi · mattdibi · commit 566d23cbadfd · 2024-12-09T10:45:06.000+01:00
diff --git a/.github/workflows/force-merge.yml b/.github/workflows/force-merge.yml
@@ -49,12 +49,11 @@ jobs:
 
             const votes = new Map();
             for(const comment of comments.data) {
-              const hasPermissions = comment.author_association === 'MEMBER' || comment.author_association === 'OWNER'
+              const hasVotingRights = comment.author_association === 'MEMBER' || comment.author_association === 'OWNER'
               const hasCastedVote = comment.body === '/force-merge'
 
-              if(hasPermissions && hasCastedVote) {
-                const username = comment.user.login
-                votes.set(username, comment.author_association);
+              if(hasVotingRights && hasCastedVote) {
+                votes.set(comment.user.login, comment.author_association);
               }
             }
 

Original file line number	Diff line number	Diff line change
`@@ -49,12 +49,11 @@ jobs:`
`49`	`49`
`50`	`50`	`const votes = new Map();`
`51`	`51`	`for(const comment of comments.data) {`
`52`		`- const hasPermissions = comment.author_association === 'MEMBER' \|\| comment.author_association === 'OWNER'`
	`52`	`+ const hasVotingRights = comment.author_association === 'MEMBER' \|\| comment.author_association === 'OWNER'`
`53`	`53`	`const hasCastedVote = comment.body === '/force-merge'`
`54`	`54`
`55`		`- if(hasPermissions && hasCastedVote) {`
`56`		`- const username = comment.user.login`
`57`		`- votes.set(username, comment.author_association);`
	`55`	`+ if(hasVotingRights && hasCastedVote) {`
	`56`	`+ votes.set(comment.user.login, comment.author_association);`
`58`	`57`	`}`
`59`	`58`	`}`
`60`	`59`