refactor: addressed warnings, added org.eclipse.kura:maven-enforcer-rules to ban plugins

Signed-off-by: Marcello Rinaldo Martina <martina.marcello.rinaldo@outlook.com>

Author: marcellorinaldo

kura/tools/kura-addon-archetype/src/main/resources/archetype-resources/parent/pom.xml

@@ -74,7 +74,6 @@
                         <target>17</target>
                         <showDeprecation>true</showDeprecation>
                         <showWarnings>true</showWarnings>
-                        <requireJREPackageImports>true</requireJREPackageImports>
                     </configuration>
                 </plugin>
 
@@ -177,6 +176,41 @@
                     </executions>
                 </plugin>
 
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-enforcer-plugin</artifactId>
+                    <version>3.6.2</version>
+                    <dependencies>
+                        <dependency>
+                            <groupId>org.eclipse.kura</groupId>
+                            <artifactId>maven-enforcer-rules</artifactId>
+                            <version>1.0.0-SNAPSHOT</version>
+                        </dependency>
+                    </dependencies>
+                    <executions>
+                        <execution>
+                            <id>enforce</id>
+                            <configuration>
+                                <rules>
+                                    <bannedPluginsAdvanced>
+                                        <message>Please use copy-dependencies goal instead of copy</message>
+                                        <bannedPlugins>
+                                            <bannedPlugin>
+                                                <groupId>org.apache.maven.plugins</groupId>
+                                                <artifactId>maven-dependency-plugin</artifactId>
+                                                <goal>copy</goal>
+                                            </bannedPlugin>
+                                        </bannedPlugins>
+                                    </bannedPluginsAdvanced>
+                                </rules>
+                            </configuration>
+                            <goals>
+                                <goal>enforce</goal>
+                            </goals>
+                        </execution>
+                    </executions>
+                </plugin>
+
                 <!-- This plugin's configuration is used to store Eclipse m2e settings only. It has
                 no influence on the Maven build itself. -->
                 <plugin>
@@ -258,6 +292,10 @@
                     <flattenMode>oss</flattenMode>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-enforcer-plugin</artifactId>
+            </plugin>
         </plugins>
     </build>
 

kura/tools/kura-addon-archetype/src/main/resources/archetype-resources/parent/tests/__package__.test/META-INF/MANIFEST.MF

@@ -14,4 +14,3 @@ Require-Bundle: org.junit,
 Import-Package: org.eclipse.kura;version="1.5.0",
  org.eclipse.kura.configuration;version="1.1.2",
  org.slf4j;version="1.7.25"
-Service-Component: OSGI-INF/*.xml