add createTemporaryIdentity with IdentityConfiguration arg

Signed-off-by: Nicola Timeus <nicola.timeus@eurotech.com>

Author: nicolatimeus

kura/org.eclipse.kura.api/src/main/java/org/eclipse/kura/identity/IdentityService.java

@@ -257,4 +257,25 @@ public IdentityConfiguration getIdentityDefaultConfiguration(final String identi
      */
     public void createTemporaryIdentity(final String identityName, final Duration lifetime) throws KuraException;
 
+
+    /**
+     * Creates a temporary identity that is not persisted and has automatic
+     * expiration. Temporary identities behave like regular identities but are
+     * stored in-memory only and are automatically removed after the specified
+     * lifetime period.
+     *
+     * @param identityConfiguration
+     *            the identity configuration including identity
+     *            name and optional configuration components.
+     * @param lifetime
+     *            the duration before automatic expiration. The identity
+     *            will be automatically removed after this period.
+     * @throws KuraException
+     *             if a failure occurs in creating the temporary identity,
+     *             if an identity with the given name already exists
+     *             (either regular or temporary) or if the provided configuration
+     *             is not valied.
+     * @since 2.8.0
+     */
+    public void createTemporaryIdentity(final IdentityConfiguration identityConfiguration, final Duration lifetime) throws KuraException;
 }

kura/org.eclipse.kura.core.identity/src/main/java/org/eclipse/kura/core/identity/IdentityServiceImpl.java

@@ -354,7 +354,6 @@ private AdditionalConfigurations getAdditionalConfigurationsDefaults(final Strin
         return new AdditionalConfigurations(additionalConfigurations);
     }
 
-
     private void validatePasswordConfiguration(final IdentityConfiguration identityConfiguration,
             final PasswordConfiguration passwordCofiguration) throws KuraException {
         if (!passwordCofiguration.isPasswordAuthEnabled()) {
@@ -373,8 +372,7 @@ private void validatePasswordConfiguration(final IdentityConfiguration identityC
                     .filter(u -> u.getCredentials().get(PASSWORD_PROPERTY) != null).isPresent();
             final boolean hasTemporaryPasswordHash = this.temporaryStore.getIdentity(identityConfiguration.getName())
                     .flatMap(config -> config.getComponent(PasswordConfiguration.class))
-                    .flatMap(PasswordConfiguration::getPasswordHash)
-                    .isPresent();
+                    .flatMap(PasswordConfiguration::getPasswordHash).isPresent();
             if (!hasPersistedPasswordHash && !hasTemporaryPasswordHash) {
                 throw new KuraException(KuraErrorCode.INVALID_PARAMETER,
                         "Password authentication is enabled but no password has been provided or is currently assigned");
@@ -411,6 +409,15 @@ private void validateAdditionalConfigurations(final IdentityConfiguration identi
     public synchronized void createTemporaryIdentity(final String identityName, final Duration lifetime)
             throws KuraException {
 
+        createTemporaryIdentity(new IdentityConfiguration(identityName, Collections.emptyList()), lifetime);
+    }
+
+    @Override
+    public synchronized void createTemporaryIdentity(final IdentityConfiguration identityConfiguration,
+            final Duration lifetime) throws KuraException {
+
+        final String identityName = identityConfiguration.getName();
+
         ValidationUtil.validateNewIdentityName(identityName);
 
         // Check if identity already exists (temporary or regular)
@@ -429,8 +436,8 @@ public synchronized void createTemporaryIdentity(final String identityName, fina
                         "Temporary identity lifetime must be positive");
             }
 
-            this.temporaryIdentityStore.createIdentity(new IdentityConfiguration(identityName, Collections.emptyList()),
-                    lifetime);
+            validateIdentityConfiguration(identityConfiguration);
+            this.temporaryIdentityStore.createIdentity(identityConfiguration, lifetime);
 
         }, "Create temporary identity " + identityName);
     }