NPM Clean Install Issue?

[snarkipus]

Tag: @msujew

So, I've gotten in the habit of running npm ci periodically since I'm prone to making a mess (still haven't sorted out the jest issue).

For some reason, the build failed, and I narrowed it down to an unhandled undefined in the workspace manager link.

For now, I just did this which passes all of the tests (probably not good), but I'm fairly sure this isn't actually what was intended:

services.lsp.LanguageServer.onInitialize(params => {
    if (params.workspaceFolders === undefined) {
        throw new Error('WorkspaceFolder[] is undefined.');
    } else {
        this.folders = params.workspaceFolders;
    }
});

Since it's entirely possible I inadvertently broke something, I thought I'd ask first. However, I do see that this was just recently touched in this commit so maybe it just snuck through and nobody has seen it yet.

[msujew]

In what sense did the build break? Did TypeScript complain that params.workspaceFolders can be undefined? Because that's not the case per the typings. Even if it were during runtime, we deal correctly with it later.

[snarkipus]

For some reason, this is the typings that I get ... maybe it's something weird on my end.

[msujew]

Interesting. It seems like Microsoft released a breaking change between 8.0.1 and 8.0.2, see microsoft/vscode-languageserver-node#948 of the language client/server libraries. Great...

You likely have 8.0.2 locally, while the main branch has 8.0.1 locked in. I'll update our dependencies.

[snarkipus]

Confirmed via npm list.

├─┬ [email protected] -> ./packages/langium-vscode
│ ├── @types/[email protected] deduped
│ ├── [email protected]
│ ├── [email protected]
│ ├── [email protected] deduped -> ./packages/langium
│ ├── [email protected] deduped
│ └── [email protected] deduped
├─┬ [email protected] -> ./packages/langium
│ ├── [email protected] deduped
│ ├── [email protected] deduped -> ./packages/langium-cli
│ ├── [email protected]
│ ├── [email protected] deduped
│ └── [email protected] deduped