Update project to use JSpecify (#1356)

Signed-off-by: system24seven <[email protected]>
Co-authored-by: Kevin Herron <[email protected]>

Author: system24seven

.github/workflows/google-java-format.yml

@@ -13,6 +13,11 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
+      - name: Set up Java
+        uses: actions/[email protected]
+        with:
+          distribution: "temurin"
+          java-version: 17
       - uses: axel-op/[email protected]
         with:
           args: "--set-exit-if-changed"

milo-examples/client-examples/pom.xml

@@ -52,12 +52,6 @@
       <artifactId>slf4j-simple</artifactId>
       <version>${slf4j.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.jetbrains</groupId>
-      <artifactId>annotations</artifactId>
-      <version>${jetbrains-annotations.version}</version>
-      <scope>provided</scope>
-    </dependency>
   </dependencies>
 
 

milo-examples/server-examples/pom.xml

@@ -47,12 +47,6 @@
       <artifactId>slf4j-simple</artifactId>
       <version>${slf4j.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.jetbrains</groupId>
-      <artifactId>annotations</artifactId>
-      <version>${jetbrains-annotations.version}</version>
-      <scope>provided</scope>
-    </dependency>
   </dependencies>
 
   <build>

milo-examples/server-examples/src/main/java/org/eclipse/milo/examples/server/types/CustomEnumType.java

@@ -17,7 +17,7 @@
 import org.eclipse.milo.opcua.stack.core.encoding.UaEncoder;
 import org.eclipse.milo.opcua.stack.core.types.UaEnumeratedType;
 import org.eclipse.milo.opcua.stack.core.types.builtin.ExpandedNodeId;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 public enum CustomEnumType implements UaEnumeratedType {
   Field0(0),

opc-ua-sdk/codec-json/pom.xml

@@ -37,11 +37,6 @@
       <artifactId>milo-encoding-json</artifactId>
       <version>${project.version}</version>
     </dependency>
-    <dependency>
-      <groupId>org.jetbrains</groupId>
-      <artifactId>annotations</artifactId>
-      <version>${jetbrains-annotations.version}</version>
-    </dependency>
 
     <dependency>
       <groupId>org.junit.jupiter</groupId>

opc-ua-sdk/codec-json/src/main/java/org/eclipse/milo/sdk/core/types/json/JsonCodecFactory.java

@@ -16,16 +16,19 @@
 import org.eclipse.milo.opcua.stack.core.types.structured.DataTypeDefinition;
 import org.eclipse.milo.opcua.stack.core.types.structured.EnumDefinition;
 import org.eclipse.milo.opcua.stack.core.types.structured.StructureDefinition;
+import org.jspecify.annotations.NullMarked;
 
+@NullMarked
 public class JsonCodecFactory {
 
   public static DataTypeCodec create(DataType dataType, DataTypeTree dataTypeTree) {
     DataTypeDefinition definition = dataType.getDataTypeDefinition();
 
     if (definition instanceof EnumDefinition) {
-      // If we're asked to create a DataTypeCodec and the definition is an EnumDefinition,
-      // that means it's an OptionSet subclass. True enumerations are encoded/decoded as
-      // integers, so they don't have a corresponding codec.
+      /* If we're asked to create a DataTypeCodec and the definition is an EnumDefinition,
+       * that means it's an OptionSet subclass. True enumerations are encoded/decoded as
+       * integers, so they don't have a corresponding codec.
+       */
       return new JsonOptionSetCodec(dataType);
     } else if (definition instanceof StructureDefinition) {
       return new JsonStructCodec(dataType, dataTypeTree);

opc-ua-sdk/codec-json/src/main/java/org/eclipse/milo/sdk/core/types/json/JsonConversions.java

@@ -38,8 +38,10 @@
 import org.eclipse.milo.opcua.stack.core.types.builtin.unsigned.ULong;
 import org.eclipse.milo.opcua.stack.core.types.builtin.unsigned.UShort;
 import org.eclipse.milo.opcua.stack.core.util.ArrayUtil;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 
+@NullMarked
 public class JsonConversions {
 
   // region OPC UA to JSON Conversions

opc-ua-sdk/codec-json/src/main/java/org/eclipse/milo/sdk/core/types/json/JsonStructCodec.java

@@ -58,8 +58,10 @@
 import org.eclipse.milo.opcua.stack.core.types.structured.StructureDefinition;
 import org.eclipse.milo.opcua.stack.core.types.structured.StructureField;
 import org.eclipse.milo.opcua.stack.core.util.Lazy;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
 
+@NullMarked
 public class JsonStructCodec extends GenericDataTypeCodec<JsonStruct> {
 
   private final Lazy<Map<StructureField, Object>> hints = new Lazy<>();

opc-ua-sdk/codec-json/src/test/java/org/eclipse/milo/opcua/test/types/AbstractTestType.java

@@ -23,7 +23,7 @@
 import org.eclipse.milo.opcua.stack.core.types.structured.StructureField;
 import org.eclipse.milo.opcua.stack.core.util.codegen.EqualsBuilder;
 import org.eclipse.milo.opcua.stack.core.util.codegen.HashCodeBuilder;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 public abstract class AbstractTestType extends Structure implements UaStructuredType {
   public static final ExpandedNodeId TYPE_ID = ExpandedNodeId.parse("ns=1;i=3003");

opc-ua-sdk/codec-json/src/test/java/org/eclipse/milo/opcua/test/types/ConcreteTestType.java

@@ -26,7 +26,7 @@
 import org.eclipse.milo.opcua.stack.core.types.structured.StructureField;
 import org.eclipse.milo.opcua.stack.core.util.codegen.EqualsBuilder;
 import org.eclipse.milo.opcua.stack.core.util.codegen.HashCodeBuilder;
-import org.jetbrains.annotations.Nullable;
+import org.jspecify.annotations.Nullable;
 
 public class ConcreteTestType extends AbstractTestType implements UaStructuredType {
   public static final ExpandedNodeId TYPE_ID = ExpandedNodeId.parse("ns=1;i=3006");