Investigate whether we still need s390m4check.pl

[fjeremic]

Merging of [1] caused a build break at OpenJ9 due to s390m4check.pl not liking a particular line added in Helpers.inc file:

16:17:59  line longer than 71 characters (73) '    .set TR_storeFlattenableArrayElement,TR_loadFlattenableArrayElement+1' at /home/jenkins/workspace/Build_JDK8_s390x_linux_xl_OMR/build/linux-s390x-normal-server-release/vm/compiler/../compiler/build/scripts/s390m4check.pl line 40, <FILE> line 623.
16:17:59  /home/jenkins/workspace/Build_JDK8_s390x_linux_xl_OMR/build/linux-s390x-normal-server-release/vm/compiler/../compiler/build/rules/gnu/common.mk:81: recipe for target '/home/jenkins/workspace/Build_JDK8_s390x_linux_xl_OMR/build/linux-s390x-normal-server-release/vm/compiler/../objs/compiler/z/runtime/Math.o.s' failed

s390m4check.pl was introduced to ensure line length does not exceed 71 characters to ensure when the file is fed into the assembler it doesn't choke. I'm not sure if we still have this restriction today with the compiler toolchains we use. We should validate the need for s390m4check.pl existence.

[1] eclipse-omr/omr#5278

[ehsankianifar]

I investigated this issue and confirm that we still need this check.

details:

I increased the limit and added a long record to check if it causes any problem or not, which turned out to be positive.

1. test setup: I added a new record like SETVAL(TR_aNewTagAddedJustToCheckIfTheBuildFailsOrNot,TR_transactionExit+22) in Helpers.inc file. This will be translated to TR_aNewTagAddedJustToCheckIfTheBuildFailsOrNot EQU TR_transactionExit+22 which is more that 71 characters.
2. Increase limit: I increased the length limit in the s390m4check.pl file in both openj9-omr and openj9 projects by changing the value of $MAX_LENGTH in line 31.
3. build: I used one of Jekins jobs to build JVM.
4. result: The build was failed and I observed following error in the build log which indicates that the line was truncated.

FSUM3112 Could not write //DD:SYSIN when copying from //DD:SYSIN2: EDC5003I Truncation of a record occurred during an I/O operation. (errno2=0xC0400066)

My conclusion is that the limit is still there therefore the script is needed!
@fjeremic

[hzongaro]

@r30shah - FYI