Skip to content

Commit 168548c

Browse files
committed
moved prepareSparqlQuery up to superclass
1 parent 177d218 commit 168548c

File tree

3 files changed

+10
-18
lines changed

3 files changed

+10
-18
lines changed

context-core/src/main/java/de/atb/context/persistence/common/RepositoryTDB.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import de.atb.context.common.exceptions.ConfigurationException;
1818
import de.atb.context.common.util.BusinessCase;
1919
import de.atb.context.common.util.IApplicationScenarioProvider;
20+
import de.atb.context.context.util.OntologyNamespace;
2021
import org.apache.jena.query.Dataset;
2122
import org.apache.jena.query.ReadWrite;
2223
import org.apache.jena.tdb.TDB;
@@ -74,6 +75,13 @@ protected static synchronized boolean clearDirectory(final File dir) {
7475
}
7576
}
7677

78+
public static synchronized String prepareSparqlQuery(final String query) {
79+
logger.trace("Preparing sparql query '" + query);
80+
String finalQuery = OntologyNamespace.prepareSparqlQuery(query);
81+
logger.trace("Final query is " + finalQuery);
82+
return finalQuery;
83+
}
84+
7785
/**
7886
* (non-Javadoc)
7987
*

context-extraction/src/main/java/de/atb/context/persistence/context/ContextRepository.java

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ private QueryExecution getQueryExecution(BusinessCase businessCase, String query
311311
if (query.trim().length() == 0) {
312312
throw new IllegalArgumentException("Query may not be empty!");
313313
}
314-
String finalQuery = prepareSparqlQuery(businessCase, query);
314+
String finalQuery = prepareSparqlQuery(query);
315315
Model model = dataset.getDefaultModel();
316316
OntModel ontModel;
317317
if (useReasoner) {
@@ -358,13 +358,6 @@ private synchronized ContextContainer prepareRawContextContainer(ContextContaine
358358
return container;
359359
}
360360

361-
private synchronized String prepareSparqlQuery(BusinessCase businessCase, String query) {
362-
logger.debug("Preparing sparql query '" + query + "' for business case " + businessCase);
363-
String finalQuery = OntologyNamespace.prepareSparqlQuery(query);
364-
logger.debug("Final query is " + finalQuery);
365-
return finalQuery;
366-
}
367-
368361
/**
369362
* (non-Javadoc)
370363
*
@@ -450,7 +443,7 @@ public synchronized List<String> getLastContextsIds(BusinessCase bc, TimeFrame t
450443
private synchronized List<String> getLastIds(String queryString, BusinessCase bc) throws QueryException {
451444
List<String> ids = new ArrayList<>();
452445
try {
453-
String finalQuery = prepareSparqlQuery(bc, queryString);
446+
String finalQuery = prepareSparqlQuery(queryString);
454447
Dataset ds = getDataSet(bc);
455448
ds.begin(ReadWrite.WRITE);
456449
ResultSet set = executeSelectSparqlQuery(finalQuery, ds.getDefaultModel());

context-monitoring/src/main/java/de/atb/context/persistence/monitoring/MonitoringDataRepository.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import de.atb.context.common.util.BusinessCase;
2020
import de.atb.context.common.util.SPARQLHelper;
2121
import de.atb.context.common.util.TimeFrame;
22-
import de.atb.context.context.util.OntologyNamespace;
2322
import de.atb.context.monitoring.config.models.DataSource;
2423
import de.atb.context.monitoring.models.IMonitoringDataModel;
2524
import de.atb.context.monitoring.rdf.RdfHelper;
@@ -40,7 +39,6 @@
4039

4140
import java.net.URL;
4241
import java.util.ArrayList;
43-
import java.util.Collection;
4442
import java.util.List;
4543
import java.util.stream.Collectors;
4644

@@ -473,13 +471,6 @@ public synchronized ResultSet executeSparqlSelectQuery(final BusinessCase busine
473471
});
474472
}
475473

476-
public static synchronized String prepareSparqlQuery(final String query) {
477-
logger.trace("Preparing sparql query '" + query);
478-
String finalQuery = OntologyNamespace.prepareSparqlQuery(query);
479-
logger.trace("Final query is " + finalQuery);
480-
return finalQuery;
481-
}
482-
483474
@SuppressWarnings("unchecked")
484475
private <T, D extends DataSource> IMonitoringDataModel<T, D> initLazyModel(final Model model, final Type data) {
485476
RDF2Bean bb = new RDF2Bean(model);

0 commit comments

Comments
 (0)