Missing capabilities for the implementation

[timothyjward]

Current Behavior

There is no implementation capability nor a service capability as required in the specification

Expected Behavior

The capabilities should be provided by the implementation bundle

Steps To Reproduce

No response

Version

snapshot

Are you interested in contributing a solution yourself?

None

Anything else?

No response

[laeubi]

It has this here:

jakarta-webservices/runtime/registrar/src/main/java/org/eclipse/osgi/technology/webservices/registrar/EndpointRegistrar.java

Line 54 in f88cbd2

@Capability(namespace = ImplementationNamespace.IMPLEMENTATION_NAMESPACE, //

but ti seems it is not picked up by bnd build?

[timothyjward]

but ti seems it is not picked up by bnd build?

I think it is being picked up, but the name being used is wrong. The constants update should improve things I think.

[laeubi]

but ti seems it is not picked up by bnd build?

I think it is being picked up, but the name being used is wrong. The constants update should improve things I think.

I was just confused because

There is no implementation capability nor a service capability

seem to indicate that there is not any (including a wrong) at all.

[timothyjward]

This has improved, but:

The uses constraint for the service set at

jakarta-webservices/runtime/registrar/src/main/java/org/eclipse/osgi/technology/webservices/registrar/EndpointRegistrar.java

Line 63 in 45db41c

+ ":List<String>=\"org.osgi.service.webservice.runtime.WebserviceServiceRuntime\";uses:=\"org.osgi.service.webservice.runtime\"" })

does not match the requirement from the specification:

uses:="org.osgi.service.webservice.runtime,org.osgi.service.webservice.runtime.dto,jakarta.xml.ws.handler,jakarta.xml.ws,org.osgi.dto,org.osgi.framework.dto"

The uses constraint for the implementation set at

jakarta-webservices/runtime/registrar/src/main/java/org/eclipse/osgi/technology/webservices/registrar/EndpointRegistrar.java

Line 60 in 45db41c

name = WebserviceWhiteboardConstants.WEBSERVICE, //

does not match the requirement from the specification:

uses:="org.osgi.service.webservice.runtime,org.osgi.service.webservice.runtime.dto,jakarta.xml.ws.handler,jakarta.xml.ws,org.osgi.dto,org.osgi.framework.dto" 

The value for the implementation set at

jakarta-webservices/runtime/registrar/src/main/java/org/eclipse/osgi/technology/webservices/registrar/EndpointRegistrar.java

Line 60 in 45db41c

name = WebserviceWhiteboardConstants.WEBSERVICE, //

does not match the requirement from the specification:

osgi.webservice

[laeubi]

The uses constraints are automatically computed, so I would assume they are correct here, I don't know why it was requested to have more uses constraint in the spec.

[timothyjward]

The uses constraints are automatically computed, so I would assume they are correct here, I don't know why it was requested to have more uses constraint in the spec.

For the capability annotation the uses constraint is computed based on the packages of the types that you pass in. The constraints should be appropriate for the capability type. The service requires you to use API, so it should be enough to list the one and only package. The implementation capability however needs to be a little more careful as people may only use a few of the packages.

I would expect

uses:="org.osgi.service.webservice.runtime,org.osgi.service.webservice.runtime.dto"

and

uses:="jakarta.xml.ws.handler,jakarta.xml.ws,jakarta.jws"

to be fine, but you're the expert.