Skip to content

Assums that file ModTime is sufficient for ordering (queue/store) - possible out-of-order queue/store #342

Description

@MattBrittan

Describe the bug

TestFileQueue is failing on Linux.

I suspect this may be a wider issue in that Linux may use a "‘coarse’ current time" ref meaning that files written rapidly in succession may end up with the same timestamp.

This will impact the queue and state store. I suspect that it's not something that would be seen often in reality because messages arriving over a network link are unlikely to be all that close. However when queuing messages it could be an issue (both in the message queue and state store). Note that this would also impact the V3 client filestore.

Impacts:

  • Potential for queued messages to be delivered out of order
  • Potential for messages resent from store to be out of order

To reproduce
Run test on Linux (kernel 7.1.9-200.fc44.x86_64, btrfs / tmpfs).

Expected behaviour
Expect files to be ordered.

Software used:
@master

Additional context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions