Recovering from a "The profile is not locked" error

[ptziegler]

This is an issue that pops up every now and then, whenever I try to open the target editor. Usually immediately after the start, when I open the target file while PDE is still initializing. The problem: This error simply doesn't go away, even after a restart and therefore makes it impossible to reload the target platform.

Based on the stack trace, it seems like the internal data of PDE gets corrupted, where it thinks a profile is locked, even though it isn't.

java.lang.IllegalStateException: The profile is not locked.
	at org.eclipse.equinox.internal.p2.engine.ProfileLock.unlock(ProfileLock.java:131)
	at org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry.internalUnlockProfile(SimpleProfileRegistry.java:1012)
	at org.eclipse.equinox.internal.p2.engine.SimpleProfileRegistry.removeProfile(SimpleProfileRegistry.java:512)
	at org.eclipse.pde.internal.core.target.P2TargetUtils.deleteProfileWithId(P2TargetUtils.java:306)
	at org.eclipse.pde.internal.core.target.P2TargetUtils.deleteProfile(P2TargetUtils.java:298)
	at org.eclipse.pde.internal.ui.editor.targetdefinition.TargetEditor$TargetChangedListener$1.run(TargetEditor.java:688)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)

Is there a different way to gracefully recover from this or do I have to nuke the .metadata folder?

[laeubi]

@ptziegler maybe we can improve P2 itself in this regard? deleting an non-existing profile should simply be a no-op...

[ptziegler]

deleting an non-existing profile should simply be a no-op...

I'm not really sure whether that's really the case here. As said, it's something that only happens sporadicallly (I think while PDE was updating the plugin dependencies, while Oomph was updating the IDE and while opening the target editor, all at the same time).

It feels like something broke there and this exception is just one of the (potentially) many things that might no longer work properly. Though what definitely could be improved is the error message: At least it should specify which profile is not locked.