[2011] Improve SysML validation to be more modular

Notes:
* Had to tweak JDT formatter setting
"org.eclipse.jdt.core.formatter.alignment_for_enum_constants" so we get
a newline for each enum literal even if it does not have Javadoc.
* Had to tweak JDT formatter setting
"org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer"
to be in-line with the formatting expected by Checkstyle.

Bug: #2011
Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>

Author: flatombe

CHANGELOG.adoc

@@ -23,6 +23,16 @@ The following methods have been added:
 - https://github.com/eclipse-syson/syson/issues/1988[#1988] [syson] Extract Elasticsearch container initialization in a dedicated abstract test class.
 The property `SysONTestsProperties#ELASTICSEARCH` has been removed, tests that require Elasticsearch should extend `AbstractIntegrationTestsWithElasticsearch`.
 
+- [validation] The following classes have been renamed, and some of them reworked:
+
+** `org.eclipse.syson.sysml.validation.SysMLv2ValidationRules`: turned into enumeration `org.eclipse.syson.sysml.validation.rules.SysMLValidationRule`.
+** `org.eclipse.syson.sysml.validation.SysMLv2ValidationService`: renamed into `org.eclipse.syson.sysml.validation.SysONSysMLValidationService`.
+** `org.eclipse.syson.sysml.validation.SysMLv2Validator`: renamed into `org.eclipse.syson.sysml.validation.SysMLValidator`.
+** `org.eclipse.syson.sysml.validation.ValidationRule`: renamed into `org.eclipse.syson.sysml.validation.rules.ValidationRule`, extracted its methods into interface `org.eclipse.syson.sysml.validation.rules.api.ISysMLValidationRule` and added `int getSeverity()` to represent the severity of the rule.
+** `org.eclipse.syson.sysml.validation.SysONQueryServices`: renamed into `org.eclipse.syson.sysml.validation.rules.SysMLValidationRuleQueryServices`.
+** `org.eclipse.syson.sysml.validation.SysMLv2ValidatorConfiguration`: renamed into `org.eclipse.syson.sysml.validation.SysMLValidatorRegistrationConfiguration` and now expects an injected `org.eclipse.syson.sysml.validation.rules.api.ISysMLValidationRulesProvider`, for which SysON provides default implementation `org.eclipse.syson.sysml.validation.rules.SysONValidationRulesProvider`.
+
+
 === Dependency update
 
 - [releng] Update to https://github.com/eclipse-sirius/sirius-web[Sirius Web 2026.1.3]
@@ -88,6 +98,16 @@ Instead SysON will now use the inherited elements without redefining them first,
 - https://github.com/eclipse-syson/syson/issues/1994[1994] [syson] Add support for excluding libraries in the _Search_ view.
 The _Search in libraries_ toggle in the _Search_ view allows to include elements from user and standard libraries in the search.
 This toggle is de-activated by default.
+- https://github.com/eclipse-syson/syson/issues/2011[#2011] [validation] Improve SysML validation to be more modular:
+Add interface `ISysMLValidationRulesProvider` in charge of providing the validation rules to execute on SysML models.
+The default implementation, `SysONValidationRulesProvider` always provides all validation rules from the SysML specification.
+Downstream applications can override this to choose (possibly dynamically) which rules get executed.
+Add interface `ISysMLValidationRule` for the validation rules supported by our validation service, so downstream applications can easily execute their custom rules without having to implement their own service.
+The SysML validation rules from the specification have been turned into literals of enumeration `SysMLValidationRule` that implements this interface.
+Add a few simple unit tests to help maintain this enumeration.
+Add possibility for validation rules to specify their severity ; the SysML rules from the specification remain as WARNINGs for now.
+Tweak the diagnostic messages to help users understand where the erroneous element is in their editing context.
+Make sure diagnostics are sorted according to their validated element and its containing document.
 
 === New features
 

backend/application/syson-sysml-validation/.settings/org.eclipse.jdt.core.prefs

@@ -145,7 +145,7 @@ org.eclipse.jdt.core.formatter.alignment_for_compact_if=16
 org.eclipse.jdt.core.formatter.alignment_for_compact_loops=16
 org.eclipse.jdt.core.formatter.alignment_for_conditional_expression=80
 org.eclipse.jdt.core.formatter.alignment_for_conditional_expression_chain=0
-org.eclipse.jdt.core.formatter.alignment_for_enum_constants=0
+org.eclipse.jdt.core.formatter.alignment_for_enum_constants=17
 org.eclipse.jdt.core.formatter.alignment_for_expressions_in_array_initializer=16
 org.eclipse.jdt.core.formatter.alignment_for_expressions_in_for_loop_header=0
 org.eclipse.jdt.core.formatter.alignment_for_expressions_in_switch_case_with_arrow=0
@@ -229,7 +229,7 @@ org.eclipse.jdt.core.formatter.comment.new_lines_at_javadoc_boundaries=true
 org.eclipse.jdt.core.formatter.comment.preserve_white_space_between_code_and_line_comments=false
 org.eclipse.jdt.core.formatter.compact_else_if=true
 org.eclipse.jdt.core.formatter.continuation_indentation=2
-org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer=2
+org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer=1
 org.eclipse.jdt.core.formatter.disabling_tag=@formatter\:off
 org.eclipse.jdt.core.formatter.enabling_tag=@formatter\:on
 org.eclipse.jdt.core.formatter.format_guardian_clause_on_one_line=false

…ation/SysMLv2ValidatorConfiguration.java …LValidatorRegistrationConfiguration.javabackend/application/syson-sysml-validation/src/main/java/org/eclipse/syson/sysml/validation/SysMLv2ValidatorConfiguration.java renamed to backend/application/syson-sysml-validation/src/main/java/org/eclipse/syson/sysml/validation/SysMLValidatorRegistrationConfiguration.java backend/application/syson-sysml-validation/src/main/java/org/eclipse/syson/sysml/validation/SysMLv2ValidatorConfiguration.java renamed to backend/application/syson-sysml-validation/src/main/java/org/eclipse/syson/sysml/validation/SysMLValidatorRegistrationConfiguration.java

@@ -1,5 +1,5 @@
 /*******************************************************************************
- * Copyright (c) 2025 Obeo.
+ * Copyright (c) 2025, 2026 Obeo.
  * This program and the accompanying materials
  * are made available under the terms of the Eclipse Public License v2.0
  * which accompanies this distribution, and is available at
@@ -16,6 +16,7 @@
 
 import org.eclipse.emf.ecore.EValidator.Registry;
 import org.eclipse.syson.sysml.SysmlPackage;
+import org.eclipse.syson.sysml.validation.rules.api.IValidationRulesProvider;
 import org.springframework.context.annotation.Configuration;
 
 import jakarta.annotation.PostConstruct;
@@ -24,18 +25,22 @@
  * Configuration of the SysMLv2 Validator.
  *
  * @author arichard
+ * @see SysONSysMLValidationService
  */
 @Configuration
-public class SysMLv2ValidatorConfiguration {
+public class SysMLValidatorRegistrationConfiguration {
+
+    private final IValidationRulesProvider validationRulesProvider;
 
     private final Registry eValidatorRegistry;
 
-    public SysMLv2ValidatorConfiguration(Registry eValidatorRegistry) {
+    public SysMLValidatorRegistrationConfiguration(final IValidationRulesProvider validationRulesProvider, final Registry eValidatorRegistry) {
+        this.validationRulesProvider = Objects.requireNonNull(validationRulesProvider);
         this.eValidatorRegistry = Objects.requireNonNull(eValidatorRegistry);
     }
 
     @PostConstruct
     public void registerDomainValidator() {
-        this.eValidatorRegistry.put(SysmlPackage.eINSTANCE, new SysMLv2Validator());
+        this.eValidatorRegistry.put(SysmlPackage.eINSTANCE, new SysONSysMLValidator(this.validationRulesProvider));
     }
 }