ensure all files present in filters

Signed-off-by: Colin Grant <[email protected]>

Author: egocalr

packages/filesystem/src/browser/file-dialog/file-dialog-tree-filters-renderer.tsx

@@ -36,26 +36,24 @@ export class FileDialogTreeFilters {
 
 export class FileDialogTreeFiltersRenderer extends ReactRenderer {
 
+    readonly appliedFilters: FileDialogTreeFilters;
+
     constructor(
-        readonly filters: FileDialogTreeFilters,
+        readonly suppliedFilters: FileDialogTreeFilters,
         readonly fileDialogTree: FileDialogTree
     ) {
         super();
+        this.appliedFilters = { 'All Files': [], ...suppliedFilters, };
     }
 
     protected readonly handleFilterChanged = (e: React.ChangeEvent<HTMLSelectElement>) => this.onFilterChanged(e);
 
     protected doRender(): React.ReactNode {
-        if (!this.filters) {
+        if (!this.appliedFilters) {
             return undefined;
         }
 
-        const fileTypes = ['All Files'];
-        Object.keys(this.filters).forEach(element => {
-            fileTypes.push(element);
-        });
-
-        const options = fileTypes.map(value => this.renderLocation(value));
+        const options = Object.keys(this.appliedFilters).map(value => this.renderLocation(value));
         return <select className={'theia-select ' + FILE_TREE_FILTERS_LIST_CLASS} onChange={this.handleFilterChanged}>{...options}</select>;
     }
 
@@ -67,7 +65,7 @@ export class FileDialogTreeFiltersRenderer extends ReactRenderer {
         const locationList = this.locationList;
         if (locationList) {
             const value = locationList.value;
-            const filters = this.filters[value];
+            const filters = this.appliedFilters[value];
             this.fileDialogTree.setFilter(filters);
         }