Title bar style preference unnecessarily written to settings.json

[colin-grant-work]

Bug Description:

Follow-up on #16236. When filing that issue, I wasn't sure how the window.titleBarStyle setting had gotten into my settings.json file: I'd had the machine for quite a while, so it was possible I'd written it there myself some time ago and forgotten it. However, I've just set up a completely new machine and then found that the preference has been written into my settings.json file with the default value without my having done anything, and without it in fact being meaningful on my platform.

Steps to Reproduce:

0. (On MacOS)
1. Remove your user-scoped settings.json file, or just remove any setting for window.titleBarStyle from the file.
2. Start Theia (dev) Electron.
3. Observe that a new setting.json file appears (or the setting reappears in your current file) and is populated with "window.titleBarStyle": "native" even though that setting is not relevant on MacOS, and that is the default value for Electron in any case.

Additional Information

• Operating System: MacOS Tahoe
• Theia Version: 276431d (1.65 dev)

[ndoschek]

Hi @colin-grant-work,
I just tested this with a similar preference, i.e. window.tabCloseIconPlacement. This one is only included for macOS and should behave the same way on my OS (Ubuntu), but I don't see the preference automatically written to the settings file.
Could it be that the observed behavior is related to how that specific titlebar preference is implemented?

[colin-grant-work]

Oh, yes, I believe it only affects window.titleBarStyle - I think that's what I said in all my examples?

[ndoschek]

Sorry for the confusion, that was not obvious to me 🙈
I recently looked into the window.tabCloseIconPlacement preference and automatically assumed it might be related to the include behavior.
Anyway, thanks for providing a fix so quickly! 👀