devDependencies eslint incompatibilities

[fipro78]

Bug Description:

I freshly checked out the current codebase and executed npm install. This fails with the following error:

npm error While resolving: @theia/monorepo@0.0.0
npm error Found: eslint@8.57.1
npm error node_modules/eslint
npm error   dev eslint@"8" from the root project
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^9 || ^10" from eslint-plugin-no-unsanitized@4.1.5
npm error node_modules/eslint-plugin-no-unsanitized
npm error   dev eslint-plugin-no-unsanitized@"latest" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

It seems that with eslint-plugin-no-unsanitized@4.1.5 the support for eslint 8 was removed. I was able to fix it locally by pinning the version

"eslint-plugin-no-unsanitized": "4.1.4",

Steps to Reproduce:

1. checkout the theia sources into a fresh workspace or delete the node_modules folder and the package-lock.json from a current workspace
2. run npm install

[sdirix]

Thanks for the report! This should be fixed.

If you want a more stable development experience then I can recommend using npm ci over npm install as you will then install the exact dependencies which we also use for our builds, i.e. you will not encounter breaking changes by minor version updates.