Do we want to restrict code block nesting?

[sophokles73]

Clippy supports enforcing a maximum nesting depth for code blocks.

By default, this lint is not active. Based on a recent code review, I wonder if we want to set an upper limit for the nesting depth?

@PLeVasseur @AnotherDaniel @evshary Any thoughts?

[evshary]

I prefer to leave the liberty to developers because sometimes it might be inconvenient to limit the nesting depth.
However, it's still fine for me if we decide to enable the lint rule.

[AnotherDaniel]

I feel there is no single absolute hard value for maximum nesting depth - "too much" can depend on context.

We might play around with this feature, see what the actual maximum in the code base is - and then decide if/where to fix this lint?

[PLeVasseur]

Nice find @sophokles73. Perhaps we could take @AnotherDaniel's idea and then see how it goes for a few weeks or so and revisit?

For me, I find that lint rules can help prevent lots of little nits like I left on Kai's PR, since they will just not exist.

[sophokles73]

I prefer to leave the liberty to developers because sometimes it might be inconvenient to limit the nesting depth. However, it's still fine for me if we decide to enable the lint rule.

I guess in such a case you could still add an #[allow] attribute to disable the check ...