Skip to content

Commit 8247854

Browse files
committed
Remove subscriber/subscription list pagination
1 parent 87d7e6e commit 8247854

File tree

2 files changed

+7
-41
lines changed

2 files changed

+7
-41
lines changed

up-core-api/uprotocol/core/usubscription/v3/usubscription.proto

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -215,23 +215,21 @@ message UnsubscribeResponse {}
215215
// Passed to FetchSubscribers such that we can obtain a list of subscribers to
216216
// a particular topic
217217
message FetchSubscribersRequest {
218+
reserved 2;
219+
218220
// Topic we wish to find the subscribers for
219221
uprotocol.v1.UUri topic = 1;
220-
221-
// Offset in the fetch requests
222-
optional uint32 offset = 2;
223222
}
224223

225224

226225
// Returned from FetchSubscribers(), this message contains a repeated list of
227226
// SubscriberInfo
228227
message FetchSubscribersResponse {
229-
reserved 3;
228+
reserved 2, 3;
230229
// List of subscribers
231230
repeated SubscriberInfo subscribers = 1;
232231

233232
// Set to true if the batch did not return all records
234-
optional bool has_more_records = 2;
235233
}
236234

237235

@@ -257,26 +255,24 @@ message Subscription {
257255

258256

259257
message FetchSubscriptionsRequest {
258+
reserved 3;
259+
260260
oneof request {
261261
// Topic to register/unregister to receive subscription change notifications
262262
uprotocol.v1.UUri topic = 1;
263263

264264
// Subscribers's information
265265
SubscriberInfo subscriber = 2;
266266
}
267-
268-
// Offset in the fetch requests
269-
optional uint32 offset = 3;
270267
}
271268

272269

273270
// Results from FetchSubscriptions() API
274271
message FetchSubscriptionsResponse {
272+
reserved 2;
273+
275274
// Repeated list of subscriptions for a subscriber
276275
repeated Subscription subscriptions = 1;
277-
278-
// Set to true if the batch did not return all records
279-
optional bool has_more_records = 2;
280276
}
281277

282278

up-l3/usubscription/v3/README.adoc

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -227,21 +227,6 @@ When receiving a `FetchSubscribers()` request that contains a topic that
227227
a uSubscription service *MUST* return a failure status message with link:../../../up-core-api/uprotocol/v1/ucode.proto[`UCode`] `INVALID_ARGUMENT`.
228228
****
229229

230-
[.specitem,oft-sid="req~usubscription-fetch-subscribers-stable-sorting~1",oft-needs="impl,utest"]
231-
****
232-
Subscriber entries returned by subsequent calls to the `FetchSubscribers()` function *MUST* be in identical order.
233-
****
234-
235-
[.specitem,oft-sid="req~usubscription-fetch-subscribers-has-more-records~1",oft-needs="impl,utest"]
236-
****
237-
If the list of subscribers returned in response to a `FetchSubscribers()` call does not contain all existing subscription relationships, uSubscription service *MUST* set the `has_more_records` field of the `FetchSubscribersResponse` to `true`.
238-
****
239-
240-
[.specitem,oft-sid="req~usubscription-fetch-subscribers-offset~1",oft-needs="impl,utest"]
241-
****
242-
When a client calls the `FetchSubscribers()` function with an `offset` argument, the list of subscribers returned by uSubscription service *MUST* omit all subscriber entries up to the provided offset.
243-
****
244-
245230
[#fetch-subscriptions-operation]
246231
=== FetchSubscriptions()
247232

@@ -283,21 +268,6 @@ When receiving a `FetchSubscriptions()` request that contains a subscriber URI t
283268
a uSubscription service *MUST* return a failure status message with link:../../../up-core-api/uprotocol/v1/ucode.proto[`UCode`] `INVALID_ARGUMENT`.
284269
****
285270

286-
[.specitem,oft-sid="req~usubscription-fetch-subscriptions-has-more-records~1",oft-needs="impl,utest"]
287-
****
288-
If the list of subscriptions returned in response to a `FetchSubscriptions()` call does not contain all existing subscription relationships, uSubscription service *MUST* set the `has_more_records` field of the `FetchSubscriptionsResponse` to `true`.
289-
****
290-
291-
[.specitem,oft-sid="req~usubscription-fetch-subscriptions-stable-sorting~1",oft-needs="impl,utest"]
292-
****
293-
Subscription entries returned by subsequent calls to the `FetchSubscriptions()` function *MUST* be in identical order.
294-
****
295-
296-
[.specitem,oft-sid="req~usubscription-fetch-subscriptions-offset~1",oft-needs="impl,utest"]
297-
****
298-
When a client calls the `FetchSubscriptions()` function with an `offset` argument, the list of subscriptions returned by uSubscription service *MUST* omit all subscription relationship entries up to the provided offset.
299-
****
300-
301271
[#usubscription-topic]
302272
== Topics
303273

0 commit comments

Comments
 (0)