Use const for notification resource ID

Author: AnotherDaniel

up-subscription/src/notification_manager.rs

@@ -30,6 +30,9 @@ use crate::{
     USubscriptionConfiguration,
 };
 
+// From usubscription.proto, the uprotocol.notification_topic resource ID
+pub(crate) const SOURCE_URI_RESOURCE_ID: u16 = 0x8000;
+
 // This is the core business logic for tracking and sending subscription update notifications. It is currently implemented as a single
 // event-consuming function `notification_engine()`, which is supposed to be spawned into a task, and process the various notification
 // `Events` that it can receive via tokio mpsc channel.
@@ -213,7 +216,7 @@ pub(crate) async fn notification_engine(
                         );
 
                         match UMessageBuilder::notification(
-                            configuration.get_resource_uri(0x8000),
+                            configuration.get_resource_uri(SOURCE_URI_RESOURCE_ID),
                             subscribers_entry.clone(),
                         )
                         .build_with_protobuf_payload(&update)

up-subscription/src/tests/notification_manager_tests.rs

@@ -30,7 +30,7 @@ mod tests {
     use crate::{
         configuration::DEFAULT_COMMAND_BUFFER_SIZE,
         helpers,
-        notification_manager::{notification_engine, NotificationEvent},
+        notification_manager::{notification_engine, NotificationEvent, SOURCE_URI_RESOURCE_ID},
         test_lib,
         usubscription::{SubscriberUUri, TopicUUri},
         USubscriptionConfiguration,
@@ -279,7 +279,7 @@ mod tests {
         // this is the expected direct notification message
         let config = Arc::new(CommandSender::get_config());
         let expected_notitication_message = UMessageBuilder::notification(
-            config.get_resource_uri(0x8000),
+            config.get_resource_uri(SOURCE_URI_RESOURCE_ID),
             interested_subscriber_uri.clone(),
         )
         .with_message_id(UUID::build())