Skip to content

Commit 516b8af

Browse files
Fix bug in unregister_listener method (#17)
1 parent 60fa1c5 commit 516b8af

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

up_transport_zenoh/uptransportzenoh.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -340,33 +340,33 @@ async def unregister_listener(
340340
# Publish & Notification
341341
if flag & (MessageFlag.PUBLISH | MessageFlag.NOTIFICATION):
342342
# Get Zenoh key
343-
zenoh_key = ZenohUtils.to_zenoh_key_string(source_filter, sink_filter)
343+
zenoh_key = ZenohUtils.to_zenoh_key_string(self.authority_name, source_filter, sink_filter)
344344
return self._remove_publish_listener(zenoh_key, listener)
345345
# RPC request
346346
if flag & MessageFlag.REQUEST:
347347
# Get Zenoh key
348-
zenoh_key = ZenohUtils.to_zenoh_key_string(source_filter, sink_filter)
348+
zenoh_key = ZenohUtils.to_zenoh_key_string(self.authority_name, source_filter, sink_filter)
349349
return self._remove_request_listener(zenoh_key, listener) # RPC response
350350
if flag & MessageFlag.RESPONSE:
351351
if sink_filter is not None:
352352
# Get Zenoh key
353-
zenoh_key = ZenohUtils.to_zenoh_key_string(sink_filter, source_filter)
353+
zenoh_key = ZenohUtils.to_zenoh_key_string(self.authority_name, sink_filter, source_filter)
354354
return self._remove_response_listener(zenoh_key)
355355
else:
356356
return UStatus(code=UCode.INVALID_ARGUMENT, message="Sink should not be None in Response")
357357

358358
def _remove_response_listener(self, zenoh_key: str) -> UStatus:
359359
with self.rpc_callback_lock:
360360
if self.rpc_callback_map.pop(zenoh_key, None) is None:
361-
msg = "RPC response callback doesn't exist"
361+
msg = f"RPC response callback doesn't exist for : {zenoh_key}"
362362
logging.error(msg)
363363
return UStatus(code=UCode.NOT_FOUND, message=msg)
364364
return UStatus(code=UCode.OK)
365365

366366
def _remove_publish_listener(self, zenoh_key: str, listener: UListener) -> UStatus:
367367
with self.subscriber_lock:
368368
if self.subscriber_map.pop((zenoh_key, listener), None) is None:
369-
msg = "Listener not registered for filters: {source_filter}, {sink_filter}"
369+
msg = f"Listener not registered for : {zenoh_key}"
370370
logging.error(msg)
371371
return UStatus(code=UCode.NOT_FOUND, message=msg)
372372

@@ -375,7 +375,7 @@ def _remove_publish_listener(self, zenoh_key: str, listener: UListener) -> UStat
375375
def _remove_request_listener(self, zenoh_key: str, listener: UListener) -> UStatus:
376376
with self.queryable_lock:
377377
if self.queryable_map.pop((zenoh_key, listener), None) is None:
378-
msg = "RPC request listener doesn't exist"
378+
msg = f"RPC request listener doesn't exist for : {zenoh_key}"
379379
logging.error(msg)
380380
return UStatus(code=UCode.NOT_FOUND, message=msg)
381381
return UStatus(code=UCode.OK, message="Listener removed successfully")

0 commit comments

Comments
 (0)