Vert.x HTTP client should sanitize chunked transfer encoding header for HTTP/2

Motivation:

One should use setChunked on HttpClientRequest to set the chunked encoding header when necessary, however the user of the request might not be aware of this and set manually a chunked transfer-encoding header, such as the client form API.

Changes:

Remove the transfer encoding header in HTTP/2 client stream before passing headers to the actual implementation.

Add client multipart / form tests.

Author: vietj

vertx-core/src/main/java/io/vertx/core/http/impl/HttpClientRequestImpl.java

@@ -527,7 +527,6 @@ private Future<Void> doWrite(ByteBuf buff, boolean end, boolean connect) {
       if (uri.isEmpty()) {
         uri = "/";
       }
-      HostAndPort a;
       HttpRequestHead head = new HttpRequestHead(method, uri, headers, authority(), absoluteURI(), traceOperation);
       future = stream.writeHead(head, chunked, buff, writeEnd, priority, connect);
     } else {

vertx-core/src/main/java/io/vertx/core/http/impl/http2/Http2ClientStreamImpl.java

@@ -11,13 +11,15 @@
 package io.vertx.core.http.impl.http2;
 
 import io.netty.buffer.ByteBuf;
+import io.netty.handler.codec.http.HttpHeaderValidationUtil;
 import io.netty.handler.codec.http.HttpResponseStatus;
 import io.vertx.core.Future;
 import io.vertx.core.Handler;
 import io.vertx.core.MultiMap;
 import io.vertx.core.Promise;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.http.HttpFrame;
+import io.vertx.core.http.HttpHeaders;
 import io.vertx.core.http.HttpVersion;
 import io.vertx.core.http.StreamPriority;
 import io.vertx.core.http.StreamResetException;
@@ -30,6 +32,9 @@
 import io.vertx.core.spi.metrics.ClientMetrics;
 import io.vertx.core.tracing.TracingPolicy;
 
+import java.util.Iterator;
+import java.util.Map;
+
 /**
  * @author <a href="mailto:julien@julienviet.com">Julien Viet</a>
  */
@@ -210,11 +215,12 @@ public HttpVersion version() {
   @Override
   public Future<Void> writeHead(HttpRequestHead request, boolean chunked, ByteBuf buf, boolean end, StreamPriority priority, boolean connect) {
     PromiseInternal<Void> promise = context.promise();
-
     stream = new Http2ClientStream(conn, context, tracingPolicy, decompressionSupported, clientMetrics);
-
     stream.handler(this);
-
+    MultiMap headers = request.headers;
+    if (headers != null) {
+      headers.remove(HttpHeaders.TRANSFER_ENCODING);
+    }
     stream.writeHeaders(request, buf, end, priority, promise);
     return promise.future();
   }

vertx-core/src/main/java/io/vertx/core/http/impl/http2/codec/Http1xUpgradeToH2CHandler.java

@@ -110,7 +110,7 @@ public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception
               request.headers().remove("host");
               request.headers().forEach(header -> {
                 if (!HttpHeaderValidationUtil.isConnectionHeader(header.getKey(), true)) {
-                  headers.set(header.getKey().toLowerCase(), header.getValue());
+                  headers.add(header.getKey().toLowerCase(), header.getValue());
                 }
               });
               ctx.fireChannelRead(new DefaultHttp2HeadersFrame(headers, false));

vertx-core/src/test/java/io/vertx/tests/http/fileupload/Http1xClientFileUploadTest.java

@@ -0,0 +1,14 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
+package io.vertx.tests.http.fileupload;
+
+public class Http1xClientFileUploadTest extends HttpClientFileUploadTest {
+}

vertx-core/src/test/java/io/vertx/tests/http/fileupload/Http2ClientFileUploadTest.java

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
+package io.vertx.tests.http.fileupload;
+
+import io.vertx.core.http.HttpClientOptions;
+import io.vertx.core.http.HttpServerOptions;
+import io.vertx.test.http.HttpTestBase;
+import io.vertx.tests.http.Http2TestBase;
+
+public class Http2ClientFileUploadTest extends HttpClientFileUploadTest {
+
+  @Override
+  protected HttpServerOptions createBaseServerOptions() {
+    return Http2TestBase.createHttp2ServerOptions(HttpTestBase.DEFAULT_HTTP_PORT, DEFAULT_HTTP_HOST);
+  }
+
+  @Override
+  protected HttpClientOptions createBaseClientOptions() {
+    return Http2TestBase.createHttp2ClientOptions();
+  }
+}

vertx-core/src/test/java/io/vertx/tests/http/fileupload/Http2MultiplexClientFileUploadTest.java

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
+package io.vertx.tests.http.fileupload;
+
+import io.vertx.core.http.HttpClientOptions;
+import io.vertx.core.http.HttpServerOptions;
+import io.vertx.test.http.HttpTestBase;
+import io.vertx.tests.http.Http2TestBase;
+
+public class Http2MultiplexClientFileUploadTest extends Http2ClientFileUploadTest {
+
+  @Override
+  protected HttpServerOptions createBaseServerOptions() {
+    return super.createBaseServerOptions().setHttp2MultiplexImplementation(true);
+  }
+
+  @Override
+  protected HttpClientOptions createBaseClientOptions() {
+    return super.createBaseClientOptions().setHttp2MultiplexImplementation(true);
+  }
+}

vertx-core/src/test/java/io/vertx/tests/http/fileupload/Http2WithUpgradeClientFileUploadTest.java

@@ -0,0 +1,24 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
+package io.vertx.tests.http.fileupload;
+
+import io.vertx.core.http.HttpClientOptions;
+import io.vertx.core.http.HttpVersion;
+
+public class Http2WithUpgradeClientFileUploadTest extends HttpClientFileUploadTest {
+
+  @Override
+  protected HttpClientOptions createBaseClientOptions() {
+    return new HttpClientOptions()
+      .setProtocolVersion(HttpVersion.HTTP_2)
+      .setHttp2ClearTextUpgrade(true);
+  }
+}

vertx-core/src/test/java/io/vertx/tests/http/fileupload/HttpClientFileUploadTest.java

@@ -1,12 +1,24 @@
+/*
+ * Copyright (c) 2011-2025 Contributors to the Eclipse Foundation
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License 2.0 which is available at
+ * http://www.eclipse.org/legal/epl-2.0, or the Apache License, Version 2.0
+ * which is available at https://www.apache.org/licenses/LICENSE-2.0.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR Apache-2.0
+ */
 package io.vertx.tests.http.fileupload;
 
 import io.netty.handler.codec.http.multipart.HttpPostRequestEncoder;
 import io.vertx.core.Future;
 import io.vertx.core.MultiMap;
 import io.vertx.core.buffer.Buffer;
 import io.vertx.core.http.*;
+import io.vertx.core.impl.Utils;
 import io.vertx.test.core.TestUtils;
 import io.vertx.test.http.HttpTestBase;
+import org.junit.Assume;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.rules.TemporaryFolder;
@@ -22,7 +34,7 @@
 import java.util.List;
 import java.util.function.BiConsumer;
 
-public class HttpClientFileUploadTest extends HttpTestBase {
+public abstract class HttpClientFileUploadTest extends HttpTestBase {
 
   @Rule
   public TemporaryFolder testFolder = new TemporaryFolder();
@@ -163,6 +175,7 @@ public void testFileUploadFormMultipart32K() throws Exception {
 
   @Test
   public void testFileUploadFormMultipart32M() throws Exception {
+    Assume.assumeTrue(!Utils.isWindows());
     testFileUploadFormMultipart(32 * 1024 * 1024, false);
   }