You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Incorrect Vert.x Open API 'multipleOf' validation #106
After upgrading from version 4.2.7 to 4.4.1, I have noticed that validating a number field which has 'multipleOf 0.001' defined in Open API 3 fails for numbers like 1.001, 1.01, 1.02, but passes for numbers like 0.001, 0.002.
Do you have a reproducer?
No, but the changes made in the code are transparent.
Since the OpenAPI3SchemaParser class which includes the MultipleOfValidatorFactory is marked as deprecated, is there an alternative solution planned for future releases?
For the record, the reason why the test was disabled was because the fixture test suite, was not the official openapi test suite. Given that the new implementation uses the official test suite and passed the tests, we ignored these tests as it was not a trivial fix. (Not the best solution, but we needed some help to fix the old implementation to behave correctly).
Activity
pmlopes commentedon Jun 4, 2024
For the record, the reason why the test was disabled was because the fixture test suite, was not the official openapi test suite. Given that the new implementation uses the official test suite and passed the tests, we ignored these tests as it was not a trivial fix. (Not the best solution, but we needed some help to fix the old implementation to behave correctly).
Validate multipleOf with exact decimal arithmetic