Allow absolute URL metadata patterns

Author: SteveDesmond-ca

src/Repository.php

@@ -5,9 +5,9 @@
 class Repository
 {
 	public string $url;
-	public ?string $metadata_pattern;
+	public string $metadata_pattern;
 
-	public function __construct(string $url, ?string $metadata_pattern)
+	public function __construct(string $url, string $metadata_pattern)
 	{
 		$this->url = $url;
 		$this->metadata_pattern = $metadata_pattern;
@@ -16,9 +16,12 @@ public function __construct(string $url, ?string $metadata_pattern)
 	public function getMetadataURL(string $package): string
 	{
 		$url_info = parse_url($this->url);
-		$path = $this->metadata_pattern != null
-			? str_replace("%package%", $package, $this->metadata_pattern)
-			: "/packages/{$package}.json";
-		return "{$url_info['scheme']}://{$url_info['host']}$path";
+		$metadata_info = parse_url($this->metadata_pattern);
+
+		$scheme = $metadata_info['scheme'] ?? $url_info['scheme'];
+		$host = $metadata_info['host'] ?? $url_info['host'];
+		$path = str_replace("%package%", $package, $metadata_info["path"]);
+
+		return "$scheme://$host$path";
 	}
 }

src/RepositoryAPI.php

@@ -27,7 +27,13 @@ public function getInfo(string $url, bool $verbose): ?Repository
 		try {
 			$response = $this->http_client->request('GET', "$url/packages.json");
 			$result = json_decode($response->getBody()->getContents(), true) ?? [];
-			return new Repository($url, array_key_exists('metadata-url', $result) ? $result['metadata-url'] : null);
+
+			$metadata_pattern = array_key_exists('metadata-url', $result)
+				? $result['metadata-url']
+				: "/p2/%package%.json";
+
+			return new Repository($url, $metadata_pattern);
+
 		} catch (GuzzleException $e) {
 			if ($verbose) {
 				fwrite($this->stderr, "Could not create repository for $url\n");

tests/CalculatorTest.php

@@ -105,7 +105,7 @@ public function testSkipsBadRepositories()
 			]
 		]);
 		$repo1 = null;
-		$repo2 = new Repository('', null);
+		$repo2 = new Repository('', '');
 		$api->shouldReceive('getInfo')->andReturn(
 			$repo1,
 			$repo2

tests/RepositoryAPITest.php

@@ -40,7 +40,7 @@ public function testCanGetRepositoryInfo()
 		$this->assertEquals('/metadata/%package%.json', $repo->metadata_pattern);
 	}
 
-	public function testCanGetRepositoryInfoWithoutMetadata()
+	public function testCanGetRepositoryInfoWithDefaultMetadataPattern()
 	{
 		//arrange
 		$http_client = Mockery::mock(ClientInterface::class, [
@@ -60,7 +60,7 @@ public function testCanGetRepositoryInfoWithoutMetadata()
 
 		//assert
 		$this->assertEquals('https://composer.example.com', $repo->url);
-		$this->assertNull($repo->metadata_pattern);
+		$this->assertEquals('/p2/%package%.json', $repo->metadata_pattern);
 	}
 
 	public function testRepositoryIsNullOnException()

tests/RepositoryTest.php

@@ -19,15 +19,15 @@ public function testCanGetPackageMetadataURL()
 		$this->assertEquals("https://composer.example.com/metadata/ecoapm/libyear.json", $url);
 	}
 
-	public function testCanGetDefaultPackageMetadataURL()
+	public function testCanGetAbsoluteMetadataURL()
 	{
 		//arrange
-		$repo = new Repository("https://composer.example.com/packages", null);
+		$repo = new Repository("https://composer.example.com/packages", "https://packages.example.com/metadata/%package%.json");
 
 		//act
 		$url = $repo->getMetadataURL("ecoapm/libyear");
 
 		//assert
-		$this->assertEquals("https://composer.example.com/packages/ecoapm/libyear.json", $url);
+		$this->assertEquals("https://packages.example.com/metadata/ecoapm/libyear.json", $url);
 	}
 }