Skip to content

Commit b3fc8bc

Browse files
BiomeOS Developercursoragent
andcommitted
S279: final docs sweep — stale test counts, file size claim, version stamps
CONTEXT.md: deep debt history extended to S279, test count 9,131→9,156. NEXT_STEPS.md: D-COV test counts updated (2 sites). README.md: production panics confirmed S223→S279, file size limit reworded to honestly reflect 11 cylinder VFIO files >800L (single-concern hardware sequences). CHANGELOG.md: added test-fix and debris cleanup items to S279 entry. docs/guides/TESTING.md: S273→S279, 9,131→9,156. specs/README.md: Key Numbers S211→S279 (7,842→9,156 lib tests, 65→88 methods, 49→46 unsafe, 47 crates). docs/README.md: S273→S279. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent fa87d1c commit b3fc8bc

7 files changed

Lines changed: 18 additions & 14 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,11 @@ Comprehensive deep debt audit and execution: eliminated all remaining P0/P1 prod
2121
- FIXED: `module_patch/mod.rs` — P1 `offset.unwrap()` after filter → `.filter_map()` with `p.offset?`
2222
- DEPRECATED: `get_capability_to_legacy_map()`, `capabilities_to_dependencies()` in `capability_helpers.rs` — legacy primal name mapping
2323
- DOCUMENTED: `get_platform_status()` — intentional design: sovereign primal is alive iff process runs
24+
- FIXED: `workload_executor_test.rs` — 2 `WorkloadFile` literals missing `data_dependencies` field (added S269, tests not updated)
25+
- FIXED: 3 `unibin_*_tests.rs` files — `start_servers_with_fallback()` calls missing 7th arg `jsonrpc_listener` (added S277, tests not updated)
26+
- CLEANED: `showcase/` directory removed (fossilized S275, pointer README only). Stale ignore patterns scrubbed (.gitignore, .cursorignore, .cleanignore, tarpaulin.toml). Dangling `[[bench]] jsonrpc_throughput` removed from server Cargo.toml. Migration doc `TODO`/`todo!()` replaced with completed code. S278B handoff archived.
2427
- VERIFIED: All 3 `unsafe` blocks in `hw-learn/nouveau_drm.rs` already have SAFETY comments
25-
- VERIFIED: 9,156+ lib tests pass, 0 clippy warnings
28+
- VERIFIED: All test targets compile (`cargo test --workspace --tests --no-run`). 9,156+ lib tests pass, 0 clippy warnings
2629

2730
### Session S279 (May 27, 2026) — Exp 229: Catalyst Channel — RM Compute Channel Before Warm Swap
2831

CONTEXT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ ToadStool is the **Layer 0** hardware substrate that other primals and springs d
3131
- **Peer primals**: Resolved at runtime via capability IDs and Unix-socket discovery (e.g. `capability.discover`, `resolve_capability_socket_fallback`) — not hardcoded URLs or legacy per-primal env manifests
3232
- **Discovery hierarchy** (primalSpring cross-cutting): Songbird `ipc.resolve` → biomeOS `capability.discover` → UDS filesystem convention → socket registry → TCP probing. toadStool implements tiers 1–4; TCP probing (tier 5) not used for local IPC
3333
- **Wave 8 Compute Trio** (S235–S263): `compute.dispatch.submit` trio-standard IPC contract. Phase A–D complete. NV VFIO e2e dispatch validated on Titan V (S263). **88 JSON-RPC methods.**
34-
- **Deep Debt** (S240–S273): All Duration literals → named constants. Zero production mocks/TODO/FIXME/unreachable!(). All unsafe SAFETY-documented. All `#[allow]`/`#[expect]` have `reason`. `cargo deny check bans` clean. Stale socket hygiene (S264). sporePrint Wave 28 (S265). Sandbox `working_dir` production + `data_dependencies` validation (S266). Kernel health preflight (S268). Sovereign driver rotation (S267). Production panic surface eliminated (S273). dispatch/sovereign.rs extraction (S273). warm_init module split (S273). CLI capability-based discovery migration (S273).
35-
- **Tests**: 23,000+ (9,131+ lib-only, 0 failures, unlimited parallelism)
34+
- **Deep Debt** (S240–S279): All Duration literals → named constants. Zero production mocks/TODO/FIXME/unreachable!(). All unsafe SAFETY-documented. All `#[allow]`/`#[expect]` have `reason`. `cargo deny check bans` clean. Stale socket hygiene (S264). sporePrint Wave 28 (S265). Sandbox `working_dir` production + `data_dependencies` validation (S266). Kernel health preflight (S268). Sovereign driver rotation (S267). Production panic surface eliminated (S273). dispatch/sovereign.rs extraction (S273). warm_init module split (S273). CLI capability-based discovery migration (S273). Deep Debt Evolution II — unwrap elimination, sovereign split, memmap2 removal (S276). Early Health Responder (S277). Module Extraction Sprint — 7 oversized files split, 4 C→Rust, RM ABI (S278). Panic Path Elimination III — all P0/P1 production unwraps eliminated, capability roundtrip deprecated (S279).
35+
- **Tests**: 23,000+ (9,156+ lib-only, 0 failures, unlimited parallelism)
3636
- **Unsafe**: 46 blocks (all in hw-safe/GPU/VFIO/display/plugin containment, all SAFETY-documented; reconciled S221); workspace `unsafe_code = "deny"`, 41 crates `forbid` + 5 hw crates with narrow `#[allow(unsafe_code, reason)]`; all lint attrs have `reason =` (S211+S213)
3737
- **async-trait**: DEPRECATED — fully removed and banned in `deny.toml` (S203r); transitive only via axum/config/wiggle
3838
- **deny.toml**: `ring` + `async-trait` + `zstd-sys` + `aws-lc-sys` bans active (ecoBin v3 compliant, `SOVEREIGNTY_STANDARDS.md` dark forest gate). `ring` present only as conditional transitive dep via quinn-proto/rustls-webpki (not on default build path)

NEXT_STEPS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ syntax fixed in 3 server files. Test suite fully unblocked.
3434

3535
### P1: Test Coverage → 90% (D-COV) — Ongoing (S164)
3636

37-
**~83.6% line coverage** (lib-only, 185K lines instrumented). **23,000+ tests** (0 failures, 9,131+ lib-only). Target 90%.
37+
**~83.6% line coverage** (lib-only, 185K lines instrumented). **23,000+ tests** (0 failures, 9,156+ lib-only). Target 90%.
3838

3939
**S164** expanded coverage with **+94 new tests** across 7 low-coverage files:
4040
- `resource_validator.rs` 20% → ~75% (+19 tests)
@@ -210,7 +210,7 @@ after Phase D.
210210
- [x] **Clippy pedantic clean** -- `cargo clippy --workspace --all-targets -- -D warnings -W clippy::pedantic` zero warnings (S130+)
211211
- [x] **`#[expect]` evolution** -- production `#[allow]` evolved to `#[expect(lint, reason)]` where the lint fires; ~80 justified `#[allow]` remain (S198); S131+ removed stale suppressions
212212
- [x] **Spring sync S131+** -- all 5 springs pinned to latest, SPRING_ABSORPTION_TRACKER updated (S131+)
213-
- [ ] **Test coverage target 90%** -- 23,000+ tests (9,131+ lib-only); ~83.6% line; mock hardware layers for V4L2/VFIO (MockV4l2Device, MockVfioDevice); push to 90% ongoing
213+
- [ ] **Test coverage target 90%** -- 23,000+ tests (9,156+ lib-only); ~83.6% line; mock hardware layers for V4L2/VFIO (MockV4l2Device, MockVfioDevice); push to 90% ongoing
214214
- [x] **C dep elimination** -- flate2 → rust_backend, procfs default features disabled (S129)
215215
- [x] **Capability-based ports** -- `resolve_capability_or_legacy_port()` with graceful legacy fallback (S129)
216216
- [x] **God file splits (round 4)** -- ipc/server.rs, container/lib.rs, ecosystem.rs, handler/mod.rs, nestgate/client.rs (S129)

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ Nest = Tower + Storage <- storage
5959
| Hardware transport | Implemented | DRM display, V4L2 capture, serial — frame protocol + router |
6060
| JSON-RPC surface | **88** JSON-RPC methods (direct) + semantic registry |
6161
| License | AGPL-3.0-or-later -- root LICENSE file + SPDX headers on all files |
62-
| File size limit | All production files target **< 500 lines** (S203i+S173: 52 production files refactored via test extraction; 3 specialty >700L files smart-refactored into directory modules; remaining >500L files are pure production — hardware drivers, type defs, all <700 lines) |
62+
| File size limit | Non-hardware production files target **< 500 lines**. 11 files >800L remain — all in `cylinder` VFIO hardware init (single-concern GPU bring-up sequences: pipeline, pfifo, pmu_investigate, sovereign_init, kernel_health, generation profiles, nv_gsp_bridge, reagent). S278 split 7 oversized files (~12,500L) into module dirs. |
6363
| Test concurrency | Unlimited parallelism (removed global throttle); zero `#[serial]`; test-time mDNS/TCP timeouts via `cfg!(test)`; zero fixed sleeps in non-chaos tests |
6464
| Environment safety | All env-var tests use `temp_env` (thread-safe), zero `std::env::set_var` in tests |
6565

@@ -277,7 +277,7 @@ toadStool/
277277
| Lib-only line coverage | ~83.6% |
278278
| Full workspace test time | ~7m (unlimited parallelism, `cfg!(test)` fast timeouts; GPU crates have NVK resilience wrappers) |
279279
| `unsafe` blocks | **46 actual** (all in hw-safe/GPU/VFIO/display/plugin containment crates); all SAFETY-documented (S204, reconciled S221); workspace `unsafe_code = "deny"`, **41 crates `forbid`** + 5 hw crates with narrow `#[allow(unsafe_code, reason)]` |
280-
| Production panics/unwraps | **0** production `unwrap()` / `expect()` / `panic!()` (confirmed S223) |
280+
| Production panics/unwraps | **0** production `unwrap()` / `expect()` / `panic!()` (confirmed S279) |
281281
| Production `Box<dyn Error>` | 0 in core crates -- all typed errors (thiserror) |
282282
| Production stubs | 0 blind stubs; test-only mocks **`#[cfg(test)]`** only |
283283
| Production `todo!()`/`unimplemented!()`/`dbg!()` | 0 |

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# ToadStool Documentation
22

3-
**Updated**: May 2026 — S273
3+
**Updated**: May 2026 — S279
44

55
Primary documentation lives at the repository root. See [../DOCUMENTATION.md](../DOCUMENTATION.md) for the navigation hub. Session trackers archived to `ecoPrimals/infra/wateringHole/fossilRecord/toadstool/`.
66

docs/guides/TESTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
# Testing Guide
22

3-
**Last Updated**: May 24, 2026 — S273
3+
**Last Updated**: May 27, 2026 — S279
44

55
## Quick Status
66

77
| Metric | Status | Details |
88
|--------|--------|---------|
9-
| **Lib-Only Tests** | **9,131+ (S273)** | 0 failures, unlimited parallelism |
9+
| **Lib-Only Tests** | **9,156+ (S279)** | 0 failures, unlimited parallelism |
1010
| **Workspace Tests** | **23,000+ (default features)** | ~222 intentional GPU/hardware ignores |
1111
| **Line Coverage** | **~83.6% (lib-only)** | ~185K production lines. Gap: hardware-dependent code (V4L2/VFIO/neuromorphic) |
1212
| **Clippy Pedantic** | **0 warnings** | Full workspace (`-D warnings`), in CI |

specs/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,16 @@ toadStool picks the row. coralReef compiles for it. Springs never see the table.
115115
| Test coverage | Target 90%, current ~83.6% (llvm-cov) | D-COV |
116116
| Mocks in production | 0 (all `#[cfg(test)]` gated) ||
117117

118-
### Key Numbers (S211)
118+
### Key Numbers (S279)
119119

120-
- **20,000+ workspace / 7,842 lib-only** tests (0 failures), **~65 JSON-RPC methods**
120+
- **23,000+ workspace / 9,156+ lib-only** tests (0 failures), **88+ JSON-RPC methods**
121121
- **3 hardware transports** — Display (DRM), Capture (V4L2), Serial
122-
- **VFIO interface** — BAR0, DMA, power management (nvpmu)
122+
- **VFIO interface** — BAR0, DMA, power management (nvpmu), sovereign init pipeline
123123
- **NPU dispatch** — Akida AKD1000/1500 (kernel, VFIO, userspace)
124-
- **41 crates** `#![forbid(unsafe_code)]`, **5 crates** with narrow `#[allow(unsafe_code, reason)]`**49 unsafe blocks** (all hw containment, all SAFETY-documented)
124+
- **41 crates** `#![forbid(unsafe_code)]`, **5 crates** with narrow `#[allow(unsafe_code, reason)]`**46 unsafe blocks** (all hw containment, all SAFETY-documented)
125125
- **ecoBin v3.0 certified** — pure Rust, zero C application deps
126126
- **Rust 2024 edition**, MSRV 1.85
127+
- **47 workspace crates**, zero production panics/unwraps
127128

128129
### Architecture
129130

0 commit comments

Comments
 (0)