Refactor transaction retrieval to use JSON query for OrderId in funds controller

Author: andrew

app/controllers/funds_controller.rb

@@ -30,10 +30,12 @@ def donate
     @allocation = @fund.allocations.order('created_at DESC').first
 
     if params[:OrderId].present?
-      @transaction = Transaction.find_by_legacy_id(params[:OrderId])
+      id = params[:OrderId]
+
+      @transaction = Transaction.donations.where("transactions.order->>'legacyId' = ?", id.to_s)
       if @transaction.nil?
         @fund.sync_transactions
-        @transaction = Transaction.find_by_legacy_id(params[:OrderId])
+        @transaction = Transaction.donations.where("transactions.order->>'legacyId' = ?", id.to_s)
         raise ActiveRecord::RecordNotFound unless @transaction
       end
     end

app/models/transaction.rb

@@ -13,10 +13,6 @@ class Transaction < ApplicationRecord
   scope :created_before, ->(date) { where('transactions.created_at < ?', date) }
   scope :between, ->(start_date, end_date) { where('transactions.created_at > ?', start_date).where('transactions.created_at < ?', end_date) }
 
-  def self.find_by_legacy_id(id)
-    Transaction.where("transactions.order->>'legacyId' = ?", id.to_s).first
-  end
-
   def html_url
     return unless order.present?