Refactor allocation retrieval to use slug in show and export methods; add uniqueness validation for slug in Allocation model

Author: andrew

app/controllers/allocations_controller.rb

@@ -3,7 +3,7 @@
 class AllocationsController < ApplicationController
   def show
     @fund = Fund.find_by(slug: params[:fund_id])
-    @allocation = @fund.allocations.find(params[:id])
+    @allocation = @fund.allocations.find_by(slug: params[:id])
     @project_allocations = @allocation.project_allocations.includes(:project, :funding_source).order('amount_cents desc').where('amount_cents >= 1')
   end
 
@@ -35,7 +35,7 @@ def export
 
   def export_github_sponsors
     @fund = Fund.find_by(slug: params[:fund_id])
-    @allocation = @fund.allocations.find(params[:id])
+    @allocation = @fund.allocations.find_by(slug: params[:id])
 
     csv_data = @allocation.github_sponsors_csv_export
 

app/models/allocation.rb

@@ -7,6 +7,8 @@ class Allocation < ApplicationRecord
   scope :displayable, -> { where('funded_projects_count > 0') }
   scope :completed, -> { where.not(completed_at: nil) }
 
+  validates_uniqueness_of :slug, scope: :fund_id
+
   before_create :set_slug
 
   def to_s