dev(WoRMS): fix an endpoint returning nothing valid

Author: grololo06

openapi.json

@@ -5925,7 +5925,7 @@
           "Taxonomy Tree"
         ],
         "summary":"Add Worms Taxon",
-        "description":"Add worms taxon with or without lineage information",
+        "description":"Add worms taxon by its aphia_id",
         "operationId":"add_worms_taxon",
         "requestBody":{
           "content":{
@@ -5939,7 +5939,14 @@
         },
         "responses":{
           "200":{
-            "description":"Successful Response"
+            "description":"Successful Response",
+            "content":{
+              "application/json":{
+                "schema":{
+                  "title":"Response Add Worms Taxon Addworms  Post"
+                }
+              }
+            }
           },
           "422":{
             "description":"Validation Error",

py/API_operations/TaxoManager.py

@@ -23,7 +23,6 @@
 from helpers.DynamicLogs import get_logger
 from providers.EcoTaxoServer import EcoTaxoServerClient
 from .helpers.Service import Service
-from API_models.taxonomy import TaxoWormsModel
 
 logger = get_logger(__name__)
 
@@ -78,7 +77,7 @@ def get_taxon_by_id(self, taxon_id: int) -> str:
         ret = self.client.call("/gettaxon/", {"filtertype": "id", "id": taxon_id})
         return ret.json()
 
-    def add_taxon(self, current_user_id: UserIDT, taxon_params: Dict) -> str:
+    def add_taxon(self, current_user_id: UserIDT, taxon_params: Dict) -> Any:
         # Security barrier, user must be admin or manager in any project
         #                            creation_datetime: str, =
         _user = RightsBO.user_can_add_taxonomy(self.ro_session, current_user_id)
@@ -99,12 +98,12 @@ def add_worms_taxon(
         self,
         aphia_id: int,
         current_user_id: UserIDT,
-    ) -> Dict:
+    ) -> Any:
         _user = RightsBO.user_can_add_taxonomy(self.ro_session, current_user_id)
         current_user: User = self.session.query(User).get(current_user_id)
         taxon = {"aphia_id": aphia_id, "creator_email": current_user.email}
         ret = self.client.call("/addwormstaxon/", taxon)
-        return ret
+        return ret.json()
 
     def push_stats(self) -> Any:
         """

py/main.py

@@ -3518,20 +3518,18 @@ def search_worms_name(
     "/addworms/",
     operation_id="add_worms_taxon",
     tags=["Taxonomy Tree"],
-    response_class=Response,
+    response_model=Any,
 )
 def add_worms_taxon(
     taxon: AddWormsTaxonModel = Body(...),
     _current_user: Optional[int] = Depends(get_optional_current_user),
-) -> Response:
+) -> Any:
     """
-    Add worms taxon with or without lineage information
+    Add worms taxon by its aphia_id
     """
     with CentralTaxonomyService() as sce:
-        ret = sce.add_worms_taxon(taxon.aphia_id, _current_user)
-    response = Response(json.dumps(ret.json()), media_type="application/json")
-    response.status_code = ret.status_code
-    return response
+        with RightsThrower():
+            return sce.add_worms_taxon(taxon.aphia_id, _current_user)
 
 
 # ######################## END OF TAXA_REF