fix: correct hdf5 array checkpoint conversions

Author: edengilbertus

src/io/checkpoint.rs

@@ -2,7 +2,7 @@ use std::path::Path;
 use std::time::{SystemTime, UNIX_EPOCH};
 
 use hdf5::types::VarLenUnicode;
-use hdf5::File;
+use hdf5::{File, H5Type};
 use ndarray::ArrayView3;
 use num_complex::Complex64;
 
@@ -19,16 +19,12 @@ const PSI_DATASET: &str = "psi";
 
 type ComplexRepr = [f64; 2];
 
-impl From<Complex64> for [f64; 2] {
-    fn from(value: Complex64) -> Self {
-        [value.re, value.im]
-    }
+fn to_repr(value: Complex64) -> ComplexRepr {
+    [value.re, value.im]
 }
 
-impl From<[f64; 2]> for Complex64 {
-    fn from(value: ComplexRepr) -> Self {
-        Self::new(value[0], value[1])
-    }
+fn from_repr(value: ComplexRepr) -> Complex64 {
+    Complex64::new(value[0], value[1])
 }
 
 fn io_error(err: impl std::fmt::Display) -> Error {
@@ -128,7 +124,7 @@ pub fn save_checkpoint(path: &Path, grid: &Grid3, state: &State3) -> Result<(),
     create_attr(&grid_group, "lz", &lengths[2])?;
 
     let state_group = root.create_group(STATE_GROUP).map_err(io_error)?;
-    let psi_repr: Vec<ComplexRepr> = state.psi.iter().copied().map(ComplexRepr::from).collect();
+    let psi_repr: Vec<ComplexRepr> = state.psi.iter().copied().map(to_repr).collect();
     let psi_view = ArrayView3::from_shape((shape[0], shape[1], shape[2]), &psi_repr)
         .map_err(|_| Error::InvalidFftInputLength)?;
 
@@ -200,7 +196,7 @@ pub fn load_checkpoint(path: &Path) -> Result<(Grid3, State3), Error> {
     Ok((
         grid,
         State3 {
-            psi: psi_raw.into_iter().map(Complex64::from).collect(),
+            psi: psi_raw.into_iter().map(from_repr).collect(),
         },
     ))
 }