4x5 STLs do not match bellows frames scad files

[jharlap]

Describe the bug
Using the scad files to render bellows frames (front and back) yields STLs that do not properly align with the existing STLs for both the body and the lensboard carrier. On the back, the light baffle on the frame is too widely placed to fit through the existing body STL. On the front, the screw holes for attaching the frame to the lensboard carrier are about 2mm too close to the centre and thus do not align with the existing lensboard carrier STL.

Expected behavior
Expect the bellows frames to properly fit the body and lensboard carrier.

Additional context
I have not verified the body and back frame fit for the scad files, but the front frame and lensboard carrier scad files will also not have screw holes properly aligned with the current code.

In case anyone runs into this problem at the same stage I did, my edit for the back frame was:

// in config_4x5.scad

-vBellowsBackFrameScrewHole_offsetZ = vBellowsBackFrameOuter_h/2;
+vBellowsBackFrameScrewHole_offsetZ = vBellowsBackFrameOuter_h/2 + 1;

Aside
Separate suggestion, not technically a bug as it's mentioned explicitly in the readme files:

With a well tuned printer, there's no need for the inner and outer halves of each bellows frame to be connected for the bottom layers, so to avoid having to cut and clean up the edges:

// in both bellows_front_frame.scad and bellows_back_frame.scad

-vSplitCutoutOuter_offsetZ = 0.2;
+vSplitCutoutOuter_offsetZ = 0.0;

-vSplitCutoutInner_offsetZ = 0.2;
+vSplitCutoutInner_offsetZ =  0.0;

[saint-tuesday]

@jharlap thanks for pointing me in the right direction with these edits. I figured out what was wrong with the back bellows, besides the screw hole alignment. Here's what I modified.

-vBellowsBackFrameScrewHole_offsetZ = vBellowsBackFrameOuter_h/2;
+vBellowsBackFrameScrewHole_offsetZ = vBellowsBackFrameOuter_h/2 + 2;

-vBellowsBackFrameInner_l = 135;
+vBellowsBackFrameInner_l = 131;

-vBellowsFrontFrameScrewHole_offsetXY = 40;
+vBellowsFrontFrameScrewHole_offsetXY = 43;

This shrinks the inner wall of the inner back frame by 2mm on each side. It now slots perfectly into the back plate. I needed to raise the Z level by 2mm for the screw holes to align.

For the front frame, I had each corner hole move over 3mm to line up with the lensboard carrier. The inner front frame isn't seating quite right in the lensboard carrier, but that could be an issue with the way supports were used. I'm just going to sand it down a bit.