feat(admin): command triggers show /name across the TUI surfaces (#188)

Issue #189 carried run.command onto the display records and the graph
trigger nodes for this issue's display half, but the TUI list target and
the trigger drill-in still rendered a bare dash for a command trigger, as
if it targeted nothing. The /name token now comes from one exported
vocabulary, render.mjs commandSlashLabel, used by the triggers list line,
the TUI target column and the drill-in header, so three renderings cannot
drift on what a command trigger is called; the drill-in's runs section
additionally carries the full /name-and-args line the reviewed file
staged, because the detail pane is the operator's own session and the
list keeps the name-only skimmable token.

REQ-TOPOLOGY-GRAPH UNCHANGED, checked: no graph change in this slice.
INT-TRIGGERS-FILE-CONTRACT UNCHANGED, checked: display only, the parse
and the producer surfaces are untouched.

Signed-off-by: Rob Boerman <robboerman@live.nl>

Author: edgehero

admin/src/dashboard.ts

@@ -25,7 +25,7 @@ import { makeQueue } from "@edgehero/pi-dispatch/queue";
 import { STALL_KEY } from "@edgehero/pi-dispatch/scheduler-stall-guard";
 import { windowEndAt } from "@edgehero/pi-dispatch/pause-windows";
 import { listRuns, readSettingsView, mapSchedulers, readTriggers, readPauseWindows, readStagedPackages } from "./read-model.mjs";
-import { renderStatus, renderBudget, renderTriggers, renderSettingsView } from "./render.mjs";
+import { renderStatus, renderBudget, renderTriggers, renderSettingsView, commandSlashLabel } from "./render.mjs";
 import { matchesKey } from "./keys.mjs";
 import { box, meter, clip, makeLineInput } from "./panel.mjs";
 import { makeStyler, frame, RULE } from "./style.mjs";
@@ -935,7 +935,10 @@ function matchColored(t: any, styler: any): string {
 
 function targetColored(t: any, styler: any): string {
   const arrow = styler.fg("dim", "→");
-  const flow = styler.bold(styler.fg("text", t?.flow ?? "-"));
+  // A command trigger shows its `/name` in the flow position, through render.mjs's one exported
+  // vocabulary (issue #188): before this fallback the row rendered a bare "-", as if the trigger
+  // targeted nothing.
+  const flow = styler.bold(styler.fg("text", t?.flow ?? commandSlashLabel(t) ?? "-"));
   if (t?.type === "cron") {
     // A local/cron trigger runs its flow against a folder — show `local <folder>/<flow>` so the target
     // (not just the flow name) is visible; github triggers get their repo from the webhook, so none there.
@@ -1077,7 +1080,7 @@ function renderTriggerDetail(t: any, inner: number, styler: any, sched: any = nu
 
   // Header: kind badge -> flow, plus a health marker for cron (✔ healthy / ⚠ overdue) derived from the
   // scheduler's overdueMs. A trigger with no matching scheduler shows no health marker rather than a guess.
-  let header = styler.fg(KIND_COLOR[t.type] ?? "muted", t.type ?? "?") + "  " + styler.bold(styler.fg("text", `→ ${t.flow ?? "-"}`));
+  let header = styler.fg(KIND_COLOR[t.type] ?? "muted", t.type ?? "?") + "  " + styler.bold(styler.fg("text", `→ ${t.flow ?? commandSlashLabel(t) ?? "-"}`));
   if (t.type === "cron" && sched) {
     const healthy = !sched.overdueMs;
     header += "   " + (healthy ? styler.fg("success", "✔ healthy") : styler.fg("warning", `⚠ overdue ${formatDuration(sched.overdueMs)}`));
@@ -1123,6 +1126,11 @@ function renderTriggerDetail(t: any, inner: number, styler: any, sched: any = nu
     out.push(kv("target", forgeTargetLabel(t?.forge), "accent"));
     out.push(kv("model", "deployment default", "dim"));
   }
+  // A command trigger's full `/name args` line (issue #189): the list and header show the name only,
+  // and this drill-in is where the args belong -- the reviewed file staged them, the operator's own
+  // session shows them. Rendered only when armed, on both branches, because all four kinds can carry
+  // a command; a flow trigger's pane stays byte-identical.
+  if (typeof t.command === "string" && t.command.trim() !== "") out.push(kv("command", `/${t.command.trim()}`, "accent"));
   // Same shape as the model row -- a per-trigger override of a deployment default -- and rendered on BOTH
   // branches, because unlike model, all four kinds can carry an image. The dim "deployment default" is
   // deliberate rather than an omitted row: a missing row would read as "I don't know", this reads as

admin/src/render.mjs

@@ -167,12 +167,7 @@ export function renderTriggers({ schedulers, triggers } = {}) {
  * suffix is empty and appended last.
  */
 function triggerLine(t) {
-  // A command trigger (issue #189, `run.command`) shows `/name` in the flow position: the shared parser
-  // makes flow and command mutually exclusive, so the column never has to hold both, and the slash marks
-  // "dispatches a registered extension command" apart from a flow at a glance. The NAME only (the first
-  // space-delimited token) so the line stays skimmable, the [skills basename] doctrine restated; the args
-  // belong in the detail view.
-  const flow = t?.flow ?? (typeof t?.command === "string" && t.command.trim() !== "" ? `/${t.command.trim().split(/\s+/)[0]}` : "-");
+  const flow = t?.flow ?? commandSlashLabel(t) ?? "-";
   const forge = t?.forge && t.forge !== "github" ? `  [${t.forge}]` : "";
   const pkgs = t?.packages === true ? "  [packages]" : "";
   const img = t?.image ? `  [image ${t.image}]` : "";
@@ -210,6 +205,19 @@ function triggerLine(t) {
   }
 }
 
+/**
+ * The `/name` display token for a command trigger (issue #189, `run.command`), or null when the entry
+ * carries no command. It renders in the flow position: the shared parser makes flow and command mutually
+ * exclusive, so the column never has to hold both, and the slash marks "dispatches a registered extension
+ * command" apart from a flow at a glance. The NAME only (the first space-delimited token, pi's own
+ * dispatch grammar) so the line stays skimmable, the [skills basename] doctrine restated; the args belong
+ * in the detail view. Exported as the one vocabulary (issue #188): the list line here, the TUI's target
+ * column and the drill-in header must not drift on what a command trigger is called.
+ */
+export function commandSlashLabel(t) {
+  return typeof t?.command === "string" && t.command.trim() !== "" ? `/${t.command.trim().split(/\s+/)[0]}` : null;
+}
+
 function ruleClauses(rule) {
   const clauses = [];
   for (const key of ["any", "all", "none"]) {

admin/test/dashboard.test.mjs

@@ -768,6 +768,16 @@ async function renderTrigger(trigger) {
   return { list, detail: stripAnsi(comp.render(100).join("\n")) };
 }
 
+test("a command trigger's target and drill-in show /name, and the full staged line lives in the detail", async () => {
+  // Before this, both surfaces rendered a bare "-" for a command trigger, as if it targeted nothing
+  // (issue #188's display half). The /name comes from render.mjs's one exported vocabulary.
+  const { list, detail } = await renderTrigger({ type: "comment", forge: "github", phrase: "@pi deploy", flow: null, command: "deploy prod --now", packages: false, image: null, skillsDir: null, instructions: false, resume: false, replicas: null });
+  assert.ok(list.includes("/deploy"), "the target column shows the slash name, not '-'");
+  assert.equal(list.includes("deploy prod --now"), false, "the args stay out of the list row");
+  assert.ok(detail.includes("→ /deploy"), "the drill-in header names the command the way it names a flow");
+  assert.ok(detail.includes("/deploy prod --now"), "the full staged line belongs in the detail, the operator's own session");
+});
+
 test("a trigger's row names its forge ONCE -- the target says it, so no badge repeats it", async () => {
   // The badge existed because the target read `-> github` for every forge, so a gitlab row contradicted its
   // own badge. Fixing the target removed the badge's REASON to exist, not merely its wrongness. render.mjs

admin/test/render.test.mjs

@@ -2,7 +2,7 @@ import { test } from "node:test";
 import assert from "node:assert/strict";
 import { readFileSync } from "node:fs";
 import { fileURLToPath } from "node:url";
-import { renderStatus, renderRuns, renderBudget, renderTriggers, renderSettingsView, renderWhatIf } from "../src/render.mjs";
+import { renderStatus, renderRuns, renderBudget, renderTriggers, renderSettingsView, renderWhatIf, commandSlashLabel } from "../src/render.mjs";
 
 test("render.mjs has no path to raw .log content", () => {
   const src = readFileSync(fileURLToPath(new URL("../src/render.mjs", import.meta.url)), "utf8");
@@ -165,6 +165,16 @@ test("renderTriggers shows a command trigger as /name in the flow position; flow
   assert.match(neither, /comment {2}"@pi deploy" → -$/m);
 });
 
+test("commandSlashLabel is the one /name vocabulary every surface shares (issue #188)", () => {
+  // Exported so the list line here, the TUI's target column and the drill-in header cannot drift on
+  // what a command trigger is called: three renderings, one token rule.
+  assert.equal(commandSlashLabel({ command: "deploy prod --now" }), "/deploy");
+  assert.equal(commandSlashLabel({ command: "  wf  run " }), "/wf", "surrounding whitespace never reaches the token");
+  assert.equal(commandSlashLabel({ command: "" }), null);
+  assert.equal(commandSlashLabel({ flow: "fix" }), null, "a flow trigger has no slash label");
+  assert.equal(commandSlashLabel(null), null);
+});
+
 test("renderTriggers marks a packages-loading trigger and leaves a declining one unchanged", () => {
   const cron = (packages) => ({ type: "cron", id: "nightly", pattern: "0 3 * * *", folder: "/srv/p", flow: "tidy", packages });
   // `true` is what normalizeTriggerForDisplay yields for a trigger that OMITS run.packages -- the common