fix(admin): thread the ASCII glyph opt-in into the overlay styler (issue #54)

PI_DISPATCH_ASCII=1 flipped panel.mjs' glyph table but not the
overlay's own frame glyphs, the half-ASCII gap the dashboard comment
deferred with 'lands when the view PR settles'. This is that PR
settling: makeStyler now receives { ascii } from the same resolved
paths the setGlyphs funnel reads, so the frame and the panel
primitives degrade together. The opt-in stays per styler instance on
purpose, because setGlyphs must not restyle overlays behind a
styler's back (the recorded style.mjs rationale is unchanged).

Byte-identical without the opt-in, pinned by test.

Signed-off-by: Rob Boerman <robboerman@live.nl>

Author: edgehero

admin/src/dashboard.ts

@@ -175,7 +175,10 @@ export function makeDashboard({
   deps = createDashboardDeps(paths),
 }: any = {}) {
   // The overlay-only color styler, bound to pi's injected theme (null in tests -> plain, same geometry).
-  const styler = makeStyler(theme);
+  // The ascii opt-in rides the same resolved paths as panel.mjs' setGlyphs funnel, so PI_DISPATCH_ASCII=1
+  // degrades the overlay frame and the panel primitives TOGETHER -- half-ASCII output was the pending gap
+  // the old comment here deferred (issue #54's works-in-ASCII acceptance is what landed it).
+  const styler = makeStyler(theme, { ascii: paths?.asciiGlyphs === true });
   let snapshot: any = null;
   let fetching = false;
   let disposed = false;

admin/src/index.ts

@@ -816,7 +816,8 @@ async function dispatch(pi: ExtensionAPI, args: string, ctx: any): Promise<void>
   const paths = resolvePaths(process.env);
   // Glyph posture BEFORE any rendering: every /dispatch surface (the overlay, the costs view's sparkline)
   // draws through panel.mjs' active table, and this is the one funnel all subcommands pass through. The
-  // dashboard's own styler keeps its default for now -- its `ascii` opt-in lands when the view PR settles.
+  // dashboard's own styler opts in per instance (makeStyler's `ascii`, threaded from these same paths in
+  // makeDashboard), so PI_DISPATCH_ASCII now flips the overlay frame too, not only panel.mjs (issue #54).
   setGlyphs(paths.asciiGlyphs);
 
   // Drain the deployment pointer's retained one-line notice (a broken or newer pointer file) into the

admin/test/dashboard.test.mjs

@@ -93,6 +93,25 @@ test("with a theme, the framed LIST is colored (ANSI present) but every line sti
   assert.match(stripAnsi(lines.join("\n")), /PAUSED/, "plain content survives under the color");
 });
 
+test("paths.asciiGlyphs threads into the overlay styler: the frame degrades with the panel, together", async () => {
+  // PI_DISPATCH_ASCII used to flip panel.mjs' table but not the overlay's own frame glyphs -- the
+  // half-ASCII gap the old dashboard comment deferred. The opt-in is per styler instance on purpose
+  // (setGlyphs must not restyle overlays behind a styler's back), so the thread is paths -> makeStyler.
+  const comp = makeDashboard({ paths: { asciiGlyphs: true }, done() {}, tui: fakeTui(), intervalMs: 100000, deps: cannedDeps() });
+  await flush();
+  const ascii = comp.render(80);
+  await comp.dispose();
+  assert.ok(ascii[0].startsWith("+"), "ascii corners frame the overlay");
+  const joined = ascii.join("\n");
+  assert.ok(!joined.includes("┌") && !joined.includes("│") && !joined.includes("├"), "no frame box-drawing glyph leaks through the ascii overlay");
+
+  const comp2 = makeDashboard({ paths: {}, done() {}, tui: fakeTui(), intervalMs: 100000, deps: cannedDeps() });
+  await flush();
+  const box = comp2.render(80);
+  await comp2.dispose();
+  assert.ok(box[0].startsWith("┌"), "no opt-in keeps the box-drawing default, byte-identically");
+});
+
 test("before the first fetch resolves it renders a loading panel, not a crash", () => {
   // A fetch that never resolves: the panel must still render (from the null snapshot) synchronously.
   const comp = makeDashboard({