chore: update validations (#1337)

lusergit · web-flow · commit 51515551aefb · 2026-04-07T16:27:27.000+02:00
When updating ash in #1324 we did not run proper test validation. Signed-off-by: Luca Zaninotto <luca.zaninotto@secomind.com>
diff --git a/backend/lib/edgehog/astarte/cluster/validations/url.ex b/backend/lib/edgehog/astarte/cluster/validations/url.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2023 SECO Mind Srl
+# Copyright 2023-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Astarte.Cluster.Validations.URL do
   @moduledoc false
@@ -56,4 +54,10 @@ defmodule Edgehog.Astarte.Cluster.Validations.URL do
         :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/base_images/base_image/validations/base_image_not_in_use.ex b/backend/lib/edgehog/base_images/base_image/validations/base_image_not_in_use.ex
@@ -57,4 +57,10 @@ defmodule Edgehog.BaseImages.BaseImage.Validations.BaseImageNotInUse do
            "Base image is currently in use by the following running campaigns: #{campaign_names}"}
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/campaigns/campaign/validations/require_campaign_mechanism.ex b/backend/lib/edgehog/campaigns/campaign/validations/require_campaign_mechanism.ex
@@ -39,4 +39,10 @@ defmodule Edgehog.Campaigns.Campaign.Validations.RequireCampaignMechanism do
          )}
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/campaigns/campaign/validations/validate_operation_type_requirements.ex b/backend/lib/edgehog/campaigns/campaign/validations/validate_operation_type_requirements.ex
@@ -59,6 +59,12 @@ defmodule Edgehog.Campaigns.Campaign.Validations.ValidateOperationTypeRequiremen
     end
   end
 
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
+
   defp validate_upgrade_requirements(campaign_mechanism, %{tenant: tenant}) do
     release_id = Map.get(campaign_mechanism, :release_id)
     target_release_id = Map.get(campaign_mechanism, :target_release_id)
diff --git a/backend/lib/edgehog/campaigns/campaign/validations/validate_status.ex b/backend/lib/edgehog/campaigns/campaign/validations/validate_status.ex
@@ -37,6 +37,12 @@ defmodule Edgehog.Campaigns.Campaign.Validations.ValidateStatus do
     validate_transition(status, operation)
   end
 
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
+
   defp validate_transition(status, :pause) do
     case status do
       :in_progress ->
diff --git a/backend/lib/edgehog/containers/application.ex b/backend/lib/edgehog/containers/application.ex
@@ -73,13 +73,13 @@ defmodule Edgehog.Containers.Application do
     timestamps()
   end
 
+  postgres do
+    table "applications"
+  end
+
   relationships do
     has_many :releases, Edgehog.Containers.Release do
       public? true
     end
   end
-
-  postgres do
-    table "applications"
-  end
 end
diff --git a/backend/lib/edgehog/containers/container/validations/binds_format.ex b/backend/lib/edgehog/containers/container/validations/binds_format.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Containers.Container.Validations.BindsFormat do
   @moduledoc false
@@ -57,4 +55,10 @@ defmodule Edgehog.Containers.Container.Validations.BindsFormat do
   end
 
   defp valid_bind?(_), do: false
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/container/validations/cpu_period_quota_consistency.ex b/backend/lib/edgehog/containers/container/validations/cpu_period_quota_consistency.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Containers.Container.Validations.CpuPeriodQuotaConsistency do
   @moduledoc false
@@ -56,4 +54,10 @@ defmodule Edgehog.Containers.Container.Validations.CpuPeriodQuotaConsistency do
       vars: []
     ]
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/container/validations/volume_target_uniqueness.ex b/backend/lib/edgehog/containers/container/validations/volume_target_uniqueness.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Containers.Container.Validations.VolumeTargetUniqueness do
   @moduledoc false
@@ -56,4 +54,10 @@ defmodule Edgehog.Containers.Container.Validations.VolumeTargetUniqueness do
       vars: []
     ]
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/deployment/validations/device_is_compatible.ex b/backend/lib/edgehog/containers/deployment/validations/device_is_compatible.ex
@@ -39,6 +39,12 @@ defmodule Edgehog.Containers.Deployment.Validations.DeviceIsCompatible do
     end
   end
 
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
+
   defp invalid_argument_error(changeset) do
     Ash.Changeset.add_error(
       changeset,
diff --git a/backend/lib/edgehog/containers/deployment/validations/is_ready.ex b/backend/lib/edgehog/containers/deployment/validations/is_ready.ex
@@ -30,4 +30,10 @@ defmodule Edgehog.Containers.Deployment.Validations.IsReady do
         {:error,
          "This action cannot be performed because the deployment has not the desired readiness."}
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/deployment/validations/no_conflicting_campaign.ex b/backend/lib/edgehog/containers/deployment/validations/no_conflicting_campaign.ex
@@ -106,4 +106,10 @@ defmodule Edgehog.Containers.Deployment.Validations.NoConflictingCampaign do
   defp format_operation_type(operation_type) do
     Atom.to_string(operation_type)
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/validations/dangling.ex b/backend/lib/edgehog/containers/validations/dangling.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Containers.Validations.Dangling do
   @moduledoc """
@@ -39,4 +37,10 @@ defmodule Edgehog.Containers.Validations.Dangling do
         else: {:error, :resource_in_use}
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/containers/validations/is_upgrade.ex b/backend/lib/edgehog/containers/validations/is_upgrade.ex
@@ -42,6 +42,12 @@ defmodule Edgehog.Containers.Validations.IsUpgrade do
     end
   end
 
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
+
   defp parse_version(release) do
     with :error <- release.version |> get_in() |> to_string() |> Version.parse() do
       {:error, :invalid_release}
diff --git a/backend/lib/edgehog/containers/validations/same_application.ex b/backend/lib/edgehog/containers/validations/same_application.ex
@@ -39,4 +39,10 @@ defmodule Edgehog.Containers.Validations.SameApplication do
       end
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/devices/system_model/validations/either_picture_url_or_picture_file.ex b/backend/lib/edgehog/devices/system_model/validations/either_picture_url_or_picture_file.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2024 SECO Mind Srl
+# Copyright 2024-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Devices.SystemModel.Validations.EitherPictureUrlOrPictureFile do
   @moduledoc false
@@ -41,4 +39,10 @@ defmodule Edgehog.Devices.SystemModel.Validations.EitherPictureUrlOrPictureFile
         :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/files/file_download_request/validations/file_exists.ex b/backend/lib/edgehog/files/file_download_request/validations/file_exists.ex
@@ -31,4 +31,10 @@ defmodule Edgehog.Files.FileDownloadRequest.Validations.FileExists do
       :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/groups/device_group/validations/deployment_channel_absent.ex b/backend/lib/edgehog/groups/device_group/validations/deployment_channel_absent.ex
@@ -34,4 +34,10 @@ defmodule Edgehog.Groups.DeviceGroup.Validations.DeploymentChannelAbsent do
       :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/groups/device_group/validations/selector.ex b/backend/lib/edgehog/groups/device_group/validations/selector.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2024 SECO Mind Srl
+# Copyright 2024-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Groups.DeviceGroup.Validations.Selector do
   @moduledoc false
@@ -40,4 +38,10 @@ defmodule Edgehog.Groups.DeviceGroup.Validations.Selector do
         :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/groups/device_group/validations/update_channel_absent.ex b/backend/lib/edgehog/groups/device_group/validations/update_channel_absent.ex
@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025-2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.Groups.DeviceGroup.Validations.ChannelAbsent do
   @moduledoc false
@@ -35,4 +33,10 @@ defmodule Edgehog.Groups.DeviceGroup.Validations.ChannelAbsent do
       :ok
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/os_management/ota_operation/validations/base_image_source.ex b/backend/lib/edgehog/os_management/ota_operation/validations/base_image_source.ex
@@ -46,4 +46,10 @@ defmodule Edgehog.OSManagement.OTAOperation.Validations.BaseImageSource do
          message: "only one between image file or url is supported"}
     end
   end
+
+  @impl Ash.Resource.Validation
+  def batch_callbacks?(_changeset, _opts, _context), do: false
+
+  @impl Ash.Resource.Validation
+  def has_batch_validate?, do: false
 end
diff --git a/backend/lib/edgehog/validations/pem_private_key.ex b/backend/lib/edgehog/validations/pem_private_key.ex
diff --git a/backend/lib/edgehog/validations/pem_public_key.ex b/backend/lib/edgehog/validations/pem_public_key.ex
diff --git a/backend/lib/edgehog/validations/version.ex b/backend/lib/edgehog/validations/version.ex
diff --git a/backend/lib/edgehog/validations/version_requirement.ex b/backend/lib/edgehog/validations/version_requirement.ex
diff --git a/backend/mix.lock b/backend/mix.lock
