refactor: campaign subscriptions

- remove `noop` action on campaign resource that was used to trigger
subscriptions when campaign target was updated
- add subscriptions by campaign to campaign targets
- update the frontend accordingly

Signed-off-by: ArnelaL <arnela.lisic@secomind.com>

Author: ArnelaL

backend/lib/edgehog/campaigns/campaign/campaign.ex

@@ -180,12 +180,6 @@ defmodule Edgehog.Campaigns.Campaign do
       change Changes.StartExecution
     end
 
-    update :trigger_subscription do
-      description """
-      This is a nop action used only to trigger subscriptions.
-      """
-    end
-
     destroy :destroy do
       description "Deletes a Campaign"
       primary? true

backend/lib/edgehog/campaigns/campaign_target/campaign_target.ex

@@ -35,7 +35,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
   alias Edgehog.Campaigns.CampaignMechanism.FileDownload
   alias Edgehog.Campaigns.CampaignTarget
   alias Edgehog.Campaigns.CampaignTarget.Changes
-  alias Edgehog.Campaigns.CampaignTarget.Changes.TriggerCampaignSubscription
   alias Edgehog.Containers.Release
   alias Edgehog.Files.File
 
@@ -45,11 +44,27 @@ defmodule Edgehog.Campaigns.CampaignTarget do
 
   graphql do
     type :campaign_target
+
+    subscriptions do
+      pubsub EdgehogWeb.Endpoint
+
+      subscribe :campaign_targets_by_campaign do
+        action_types [:create, :update]
+        read_action :read_by_campaign
+        relay_id_translations campaign_id: :campaign
+      end
+    end
   end
 
   actions do
     defaults [:read]
 
+    read :read_by_campaign do
+      argument :campaign_id, :uuid, allow_nil?: false
+
+      get_by :campaign_id
+    end
+
     read :next_valid_target do
       description """
       Returns the next valid target.
@@ -176,7 +191,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
       require_atomic? false
 
       change set_attribute(:status, :in_progress)
-      change TriggerCampaignSubscription
     end
 
     update :mark_as_failed do
@@ -188,7 +202,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
 
       change set_attribute(:completion_timestamp, arg(:completion_timestamp))
       change set_attribute(:status, :failed)
-      change TriggerCampaignSubscription
     end
 
     update :mark_as_successful do
@@ -200,7 +213,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
 
       change set_attribute(:completion_timestamp, arg(:completion_timestamp))
       change set_attribute(:status, :successful)
-      change TriggerCampaignSubscription
     end
 
     update :increase_retry_count do
@@ -211,8 +223,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
       require_atomic? false
 
       accept [:latest_attempt]
-
-      change TriggerCampaignSubscription
     end
 
     # Deployment related updates
@@ -234,7 +244,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
 
       change set_attribute(:status, :in_progress)
       change Changes.LinkDeployment
-      change TriggerCampaignSubscription
     end
 
     update :set_deployment do
@@ -248,7 +257,6 @@ defmodule Edgehog.Campaigns.CampaignTarget do
       require_atomic? false
 
       change set_attribute(:status, :in_progress)
-      change TriggerCampaignSubscription
     end
 
     # Firmware upgrade related updates

backend/lib/edgehog/campaigns/campaign_target/changes/trigger_campaign_subscription.ex

@@ -249,63 +249,6 @@ defmodule EdgehogWeb.Schema.Subscriptions.Campaign.CampaignSubscriptionsTest do
 
       refute_push "subscription:data", _payload, 100
     end
-
-    test "receives data on campaign target update", %{
-      socket: socket,
-      tenant: tenant
-    } do
-      campaign =
-        1
-        |> campaign_with_targets_fixture(
-          tenant: tenant,
-          mechanism_type: :deployment_deploy
-        )
-        |> Ash.load!(:campaign_targets)
-
-      [campaign_target] = campaign.campaign_targets
-
-      assert campaign_target.status == :idle
-
-      campaign_updated_query = """
-      subscription CampaignUpdated($id: ID!) {
-        campaign(id: $id) {
-          updated {
-            id
-            name
-            status
-            campaignTargets{
-              edges{
-                node {
-                  id
-                  status
-                }
-              }
-            }
-          }
-        }
-      }
-      """
-
-      subscribe(
-        socket,
-        query: campaign_updated_query,
-        variables: %{
-          "id" => AshGraphql.Resource.encode_relay_id(campaign)
-        }
-      )
-
-      Campaigns.mark_target_as_successful!(campaign_target, tenant: tenant)
-
-      assert_push "subscription:data", push
-
-      assert_updated("campaign", campaign_data, push)
-
-      assert campaign_data["id"] == AshGraphql.Resource.encode_relay_id(campaign)
-
-      [%{"node" => campaign_target}] = campaign_data["campaignTargets"]["edges"]
-
-      assert campaign_target["status"] == "SUCCESSFUL"
-    end
   end
 
   defp subscribe(socket, opts \\ []) do

backend/test/edgehog_web/schema/subscriptions/campaign/campaign_subscriptions_test.exs

@@ -0,0 +1,168 @@
+#
+# This file is part of Edgehog.
+#
+# Copyright 2026 SECO Mind Srl
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+
+defmodule EdgehogWeb.Schema.Subscriptions.Campaign.CampaignTargetSubscriptionsTest do
+  @moduledoc false
+  use EdgehogWeb.SubsCase
+
+  import Edgehog.CampaignsFixtures
+
+  alias Edgehog.Campaigns
+
+  test "receive data on campaign target update for a specific campaign", %{
+    socket: socket,
+    tenant: tenant
+  } do
+    campaign =
+      campaign_with_targets_fixture(2, tenant: tenant, mechanism_type: :deployment_deploy)
+
+    [campaign_target] =
+      campaign
+      |> Ash.load!(:campaign_targets)
+      |> Map.get(:campaign_targets, [])
+      |> Enum.take(1)
+
+    subscribe(socket,
+      variables: %{
+        "campaignId" => AshGraphql.Resource.encode_relay_id(campaign)
+      }
+    )
+
+    Campaigns.mark_target_as_successful(campaign_target)
+
+    assert_push "subscription:data", push
+    assert_updated("campaignTargetsByCampaign", campaign_targets_data, push)
+
+    assert campaign_targets_data["id"] == AshGraphql.Resource.encode_relay_id(campaign_target)
+  end
+
+  test "receives multiple updates for the same campaign", %{
+    socket: socket,
+    tenant: tenant
+  } do
+    campaign =
+      campaign_with_targets_fixture(2, tenant: tenant, mechanism_type: :deployment_deploy)
+
+    [t1, t2] =
+      campaign
+      |> Ash.load!(:campaign_targets)
+      |> Map.get(:campaign_targets)
+
+    subscribe(socket,
+      variables: %{
+        "campaignId" => AshGraphql.Resource.encode_relay_id(campaign)
+      }
+    )
+
+    Campaigns.mark_target_as_successful(t1)
+    assert_push "subscription:data", _
+
+    Campaigns.mark_target_as_successful(t2)
+    assert_push "subscription:data", _
+  end
+
+  test "payload contains expected fields", %{
+    socket: socket,
+    tenant: tenant
+  } do
+    campaign =
+      campaign_with_targets_fixture(1, tenant: tenant, mechanism_type: :deployment_deploy)
+
+    [target] =
+      campaign
+      |> Ash.load!(:campaign_targets)
+      |> Map.get(:campaign_targets)
+
+    subscribe(socket,
+      variables: %{
+        "campaignId" => AshGraphql.Resource.encode_relay_id(campaign)
+      }
+    )
+
+    Campaigns.mark_target_as_successful(target)
+
+    assert_push "subscription:data", push
+    assert_updated("campaignTargetsByCampaign", data, push)
+
+    assert Map.has_key?(data, "id")
+    assert Map.has_key?(data, "status")
+    assert Map.has_key?(data, "device")
+  end
+
+  test "does not receive updates for a different campaign", %{
+    socket: socket,
+    tenant: tenant
+  } do
+    campaign1 =
+      campaign_with_targets_fixture(1, tenant: tenant, mechanism_type: :deployment_deploy)
+
+    campaign2 =
+      campaign_with_targets_fixture(1, tenant: tenant, mechanism_type: :deployment_deploy)
+
+    [target1] =
+      campaign1
+      |> Ash.load!(:campaign_targets)
+      |> Map.get(:campaign_targets)
+
+    [target2] =
+      campaign2
+      |> Ash.load!(:campaign_targets)
+      |> Map.get(:campaign_targets)
+
+    subscribe(socket,
+      variables: %{
+        "campaignId" => AshGraphql.Resource.encode_relay_id(campaign1)
+      }
+    )
+
+    Campaigns.mark_target_as_successful(target2)
+
+    refute_push "subscription:data", _
+
+    Campaigns.mark_target_as_successful(target1)
+
+    assert_push "subscription:data", _
+  end
+
+  defp subscribe(socket, opts) do
+    default_sub_gql = """
+    subscription($campaignId: ID!) {
+      campaignTargetsByCampaign(campaignId: $campaignId) {
+        updated {
+          id
+          status
+          device {
+            id
+            name
+          }
+        }
+      }
+    }
+    """
+
+    sub_gql = Keyword.get(opts, :query, default_sub_gql)
+    variables = Keyword.get(opts, :variables, %{})
+
+    ref = push_doc(socket, sub_gql, variables: variables)
+    assert_reply ref, :ok, %{subscriptionId: subscription_id}
+
+    subscription_id
+  end
+end