feat(backend): allow deletion of BaseImage used in completed campaign

Previously, a base image could not be deleted no matter what, if it had
been used in an Update Campaign. This is problematic, for example, when
the storage is full.

It is reasonable to allow a Base Image to be deleted, even if in use by
a Update Campaign, if that campaign is finished and does not need the
image anymore.

Closes #598

Signed-off-by: Damiano Mason <damiano.mason@secomind.com>

Author: Dam-99

backend/lib/edgehog/base_images/base_image/validations/base_image_not_in_use.ex

@@ -1,7 +1,6 @@
-#
 # This file is part of Edgehog.
 #
-# Copyright 2025 SECO Mind Srl
+# Copyright 2025 - 2026 SECO Mind Srl
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -16,7 +15,6 @@
 # limitations under the License.
 #
 # SPDX-License-Identifier: Apache-2.0
-#
 
 defmodule Edgehog.BaseImages.BaseImage.Validations.BaseImageNotInUse do
   @moduledoc false
@@ -42,6 +40,7 @@ defmodule Edgehog.BaseImages.BaseImage.Validations.BaseImageNotInUse do
           ^resource.id
         )
       )
+      |> Ash.Query.filter(status != :finished)
       |> Ash.Query.limit(1)
       |> Ash.read!()
 
@@ -50,7 +49,7 @@ defmodule Edgehog.BaseImages.BaseImage.Validations.BaseImageNotInUse do
         :ok
 
       [_] ->
-        {:error, field: :id, message: "Base image is currently in use by at least one campaign"}
+        {:error, field: :id, message: "Base image is currently in use by at least one running campaign"}
     end
   end
 end

backend/lib/edgehog/campaigns/campaign/campaign.ex

@@ -79,6 +79,7 @@ defmodule Edgehog.Campaigns.Campaign do
       filter expr(status in [:idle, :in_progress, :pausing])
     end
 
+    # TODO: allow filtering per base_image_id
     read :update_campaigns do
       argument :types, {:array, :atom}
       multitenancy :allow_global

backend/lib/edgehog/campaigns/campaign_mechanism/firmware_upgrade/firmware_upgrade.ex

@@ -119,7 +119,6 @@ defmodule Edgehog.Campaigns.CampaignMechanism.FirmwareUpgrade do
     belongs_to :base_image, Edgehog.BaseImages.BaseImage do
       description "The base image distributed by the update campaign."
       public? true
-      allow_nil? false
       attribute_type :id
     end
   end

backend/test/edgehog_web/schema/mutation/delete_base_image_test.exs

@@ -78,21 +78,53 @@ defmodule EdgehogWeb.Schema.Mutation.DeleteBaseImageTest do
       assert %{fields: [:id], message: "could not be found"} = extract_error!(result)
     end
 
-    test "fails if the image is used in an Update Campaign", %{
+    test "fails if the image is used in a running Update Campaign", %{
       tenant: tenant,
       base_image: base_image,
       id: id
+    } do
+      campaign =
+        CampaignsFixtures.campaign_fixture(
+          tenant: tenant,
+          base_image_id: base_image.id,
+          mechanism_type: :firmware_upgrade
+        )
+
+      Edgehog.Campaigns.mark_campaign_in_progress(campaign)
+
+      result = delete_base_image_mutation(tenant: tenant, id: id)
+
+      assert %{
+               fields: [:id],
+               message: "Base image is currently in use by at least one running campaign"
+             } =
+               extract_error!(result)
+    end
+
+    test "deletes an image if the image is used in a completed Update Campaign", %{
+      tenant: tenant,
+      base_image: fixture,
+      id: id
     } do
       CampaignsFixtures.campaign_fixture(
         tenant: tenant,
-        base_image_id: base_image.id,
+        base_image_id: fixture.id,
         mechanism_type: :firmware_upgrade
       )
 
-      result = delete_base_image_mutation(tenant: tenant, id: id)
+      expect(StorageMock, :delete, fn _ -> :ok end)
 
-      assert %{fields: [:id], message: "Base image is currently in use by at least one campaign"} =
-               extract_error!(result)
+      base_image =
+        [tenant: tenant, id: id]
+        |> delete_base_image_mutation()
+        |> extract_result!()
+
+      assert base_image["version"] == fixture.version
+
+      refute BaseImage
+             |> Ash.Query.filter(id == ^fixture.id)
+             |> Ash.Query.set_tenant(tenant)
+             |> Ash.exists?()
     end
   end