Commit e55ff46
committed
fix(ui): show placeholder for empty Hermes history_path field
Reviewer flagged the field rendering as visually empty on macOS/Linux
after 80ae5e3 cleared its hardcoded `~/.hermes/sessions` default —
reads as "config is missing" even though the backend correctly
auto-resolves via tools::hermes::hermes_home().
Add a `placeholder` prop to the Field component and pass
`<HERMES_HOME>/sessions` for the hermes row. The angle-bracket env-var
syntax signals "this is a placeholder hint, not literal text" to the
power users who reach this modal — matches the existing technical
register of the form's labels (Launch command / Extra args / etc.)
and avoids adding an i18n string across 11 locales for a hint that's
already unambiguous.1 parent d1e9452 commit e55ff46
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
| 167 | + | |
167 | 168 | | |
168 | 169 | | |
169 | 170 | | |
| |||
186 | 187 | | |
187 | 188 | | |
188 | 189 | | |
189 | | - | |
| 190 | + | |
190 | 191 | | |
191 | 192 | | |
192 | 193 | | |
193 | 194 | | |
194 | 195 | | |
195 | 196 | | |
| 197 | + | |
196 | 198 | | |
197 | 199 | | |
198 | 200 | | |
| |||
203 | 205 | | |
204 | 206 | | |
205 | 207 | | |
| 208 | + | |
206 | 209 | | |
207 | 210 | | |
208 | 211 | | |
| |||
211 | 214 | | |
212 | 215 | | |
213 | 216 | | |
| 217 | + | |
214 | 218 | | |
215 | 219 | | |
216 | 220 | | |
| |||
0 commit comments