Skip to content

Conversation

@Waleed-Mujahid
Copy link
Member

Description

Paid courses unenrollment shows refund text currently and when user tries to enroll again it gives error saying "already enrolled". This PR updates the flow the disallow users from unenrolling from paid courses

Jira

https://edlyio.atlassian.net/browse/EDLY-7231

@manan-memon
Copy link

Can't we use any other endpoint to retrieve this information? Why do we need to create a new one?

@Waleed-Mujahid
Copy link
Member Author

Waleed-Mujahid commented Dec 23, 2024

Can't we use any other endpoint to retrieve this information? Why do we need to create a new one?

@manan-memon The endpoint previously being used was course_run_refund_status but that one also returns based on if the refund expiry date has passed and give appropriate response if user can no longer refund the course. This API simplifies the logic of course_run_refund_status and only checks if user has paid for a course and returns true. There is no other to link a payment to a user and course

@Waleed-Mujahid Waleed-Mujahid merged commit 9f6c918 into develop-koa Jan 3, 2025
1 check was pending
@Waleed-Mujahid Waleed-Mujahid deleted the waleed/EDLY-7231 branch January 3, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants