feat: Update course name on rerun course creation. #695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@manan-memon can we suggest these changes on upstream? |
Comment on lines
+183
to
+189
|
|
||
| if fields and 'display_name' in fields: | ||
| user = User.objects.get(id=user_id) | ||
| course_module = modulestore().get_course(destination_course_key, depth=0) | ||
| metadata = {u'display_name': fields['display_name']} | ||
| CourseMetadata.update_from_dict(metadata, course_module, user) | ||
|
|
Member
There was a problem hiding this comment.
@muhammadali286 we need to make a decision here. We are adding a small patch of code here. We can either:
- Move this code to
edly_features_appand import this as a util, reducing number of lines changed - Keep small block of codes inside edx-platform for verbosity
Do you think it is worth it to move this code out of edx-platform
There was a problem hiding this comment.
We can Keep it here with a detailed comment mentioning
- These changes are from edly
- Why do we need it
- What this piece of code is doing.
cc: @manan-memon
Author
|
Closing this PR as the required changes are already reflected in upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.