Input type="number' validation

[andrew-shpak]

Describe the bug and the expected behavior

I am using feature useControl hook with input number. When I trying to submit value zod form said Invalid input: expected number, received string and value for instance "88" instead of 88. Also control.change does not support Set, Map, number types

Conform version

v1.13.0

Steps to Reproduce the Bug or Issue

1. Create form with 1 number field
2. Create default form with number field which contains useContol
3. Try to submit

What browsers are you seeing the problem on?

Firefox

Screenshots or Videos

Additional context

No response

[edmundhung]

Invalid input: expected number, received string suggests your schema uses z.number(), but the value was not coerced from a string. You will want to wrap it with coerceFormValue().

Also control.change does not support Set, Map, or number types.

For primitives like number, I agree it makes sense to support them. As you can pass these values to the default value and the intents too. We could serialize them to strings using the same mechanism as useForm and other hooks.

For Set and Map, though, I am less convinced. Users can already convert a Set with Array.from(set), and it's not clear what the right behavior should be for a Map in a form input.

One of the reasons these types aren't supported right now is that control.change doesn’t store values in React state like useState does. so supporting complex structures like Set or Map might give the wrong impression. What do you think?

[andrew-shpak]

Thanks, with coerceFormValue() it works. As a suggestion can we add into FormOptionsProvider flag or option to wrap schema into it ?

One of the reasons these types aren't supported right now is that control.change doesn’t store values in React state like useState does. so supporting complex structures like Set or Map might give the wrong impression. What do you think?

The only reason I see to introduce Set is to minimize boilerplate code. So yes generally I agree we can ignore Set and Map if we add support for primitives like number

[edmundhung]

Let's keep it open until I add the serialize feature 👍🏼

[edmundhung]

As a suggestion can we add into FormOptionsProvider flag or option to wrap schema into it ?

You can wrap it using the new validateSchema option that comes with #1069. This works for SPA, but I am not sure if I would recommend it for SSR app that needs to wrap the schema as well when validating on the server.